47026 - Several methods in BookmarkEntry interface doesn't throw Unimplemented exception

Status: RESOLVED WONTFIX

(Core Graveyard :: Java APIs to WebShell, enhancement, P3)

Description

[Oleg Khokhlov]

Several methods in BookmarkEntry interface, inherited from 
javax.swing.tree.MutableTreeNode:
   remove(int index),
   remove(MutableTreeNode node),
   removeFromParent(),
   setUserObject(Object obj)
doesn't throw Unimplemented exception.

Supposed solution:
1. Add string "import org.mozilla.webclient.UnimplementedException;" in file 
   RDFTreeNode.java;
2. Add string "throw new UnimplementedException("\nUnimplementedException 
   -----\n API Function BookmarkEntry::METHOD_NAME has not yet been    
   implemented.\n");" in the body of those methods in file RDFTreeNode.java;

Comment 1

[edburns]

a

Comment 2

[edburns]

Fix checked in.

Comment 3

[Oleg Khokhlov]

Unfortunatly, method setUserObject(Object obj) still doesn't throw Unimplemented 
exception.

Comment 4

[geetha.vaidyanaathan]

Adding Status whiteboard keyword to track all Webclient existing bugs

Comment 5

[Vladimir Strigun]

Also method getAllowsChildren should throw Unimplemented exception.
This method always return true:

    boolean result = true;
    return result;

Comment 6

[Alexei V. Mokeev]

Changing QA contact

Comment 7

[Vladimir Strigun]

Attachment: Patch for /mozilla/java/webclient/classes_spec/org/mozilla/webclient/wrapper_native/RDFTreeNode.java

Comment 8

[edburns]

Fix checked in.

Comment 9

[Oleg Khokhlov]

Method setUserObject(Object obj) still doesn't throw Unimplemented 
exception.
I will create an attachment with a fix.

Comment 10

[Oleg Khokhlov]

Attachment: The fix is very simple.

Comment 11

[Thomas]

Oleg, do you have any feedback concerning your fix?

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Java APIs to WebShell isn't a thing anymore. Closing.