Several methods in BookmarkEntry interface doesn't throw Unimplemented exception

REOPENED
Assigned to

Status

Core Graveyard
Java APIs to WebShell
P3
enhancement
REOPENED
17 years ago
5 years ago

People

(Reporter: Oleg Khokhlov, Assigned: edburns)

Tracking

Trunk
All
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: suntrak-n6)

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
Several methods in BookmarkEntry interface, inherited from 
javax.swing.tree.MutableTreeNode:
   remove(int index),
   remove(MutableTreeNode node),
   removeFromParent(),
   setUserObject(Object obj)
doesn't throw Unimplemented exception.

Supposed solution:
1. Add string "import org.mozilla.webclient.UnimplementedException;" in file 
   RDFTreeNode.java;
2. Add string "throw new UnimplementedException("\nUnimplementedException 
   -----\n API Function BookmarkEntry::METHOD_NAME has not yet been    
   implemented.\n");" in the body of those methods in file RDFTreeNode.java;
(Assignee)

Comment 1

17 years ago
a
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 2

17 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

17 years ago
Unfortunatly, method setUserObject(Object obj) still doesn't throw Unimplemented 
exception.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 4

17 years ago
Adding Status whiteboard keyword to track all Webclient existing bugs
Whiteboard: suntrak-n6

Comment 5

17 years ago
Also method getAllowsChildren should throw Unimplemented exception.
This method always return true:

    boolean result = true;
    return result;

Comment 6

16 years ago
Changing QA contact
QA Contact: geetha.vaidyanaathan → avm

Comment 7

16 years ago
Created attachment 34057 [details] [diff] [review]
Patch for /mozilla/java/webclient/classes_spec/org/mozilla/webclient/wrapper_native/RDFTreeNode.java
(Assignee)

Comment 8

16 years ago
Fix checked in.
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

16 years ago
Method setUserObject(Object obj) still doesn't throw Unimplemented 
exception.
I will create an attachment with a fix.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 10

16 years ago
Created attachment 48126 [details] [diff] [review]
The fix is very simple.

Comment 11

12 years ago
Oleg, do you have any feedback concerning your fix?
Component: Java APIs to WebShell → Java APIs to WebShell
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.