Closed Bug 470320 Opened 12 years ago Closed 12 years ago

Don't modify DIRS after including rules.mk

Categories

(Thunderbird :: Build Config, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

Attached patch Fix v.1Splinter Review
Per bug 466486 comment 7 and attachment 353702 [details] [diff] [review], even if this particular thing doesn't break us, we still don't want to be making changes to DIRS after rules.mk has already had a shot at it.
Attachment #353733 - Flags: review?(bugzilla)
Comment on attachment 353733 [details] [diff] [review]
Fix v.1

Despite the comment, I'm a little concerned about the change of installer/windows to before app, but I guess you've tested and it works (if not the tinderboxes should pick it up), so r=me.
Attachment #353733 - Flags: review?(bugzilla) → review+
Nah, it was a short lunch hour: let's say that I _will have_ tested, by the time I'm able to push it :)
Both ways worked just fine, but since I was already fighting invisible monsters I went with the "nobody ever got fired for copying Firefox" approach of putting installer/windows after app.

http://hg.mozilla.org/comm-central/rev/79ecad54ff34
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.