Closed Bug 470334 Opened 15 years ago Closed 15 years ago

Workers: relative urls for XHR are incorrect

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

(Keywords: addon-compat, fixed1.9.1)

Attachments

(1 file)

Patch, v1
15.69 KB, patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review
Attached patch Patch, v1 — — Splinter Review 
Relative urls are resolved against the document, not the worker. Oops.

Also, I somehow managed to break sync xhr from workers, even though i could have sworn i had tests for that. The relative url tests use them now so we shouldn't have that problem again.

Late-compat because I'm changing the C++-only init call for XHR.
Attachment #353745 - Flags: superreview?(jonas)
Attachment #353745 - Flags: review?(jonas)
You don't want to force baseURI to always be set on init time (in fact, that'll break spec-compat for main-thread-XHR). So allow null to be passed in, in which case we do what we currently do.
(In reply to comment #1)

That's what the patch does :)
Attachment #353745 - Flags: superreview?(jst)
Attachment #353745 - Flags: superreview?(jonas)
Attachment #353745 - Flags: review?(jst)
Attachment #353745 - Flags: review?(jonas)
Attachment #353745 - Flags: superreview?(jst)
Attachment #353745 - Flags: superreview+
Attachment #353745 - Flags: review?(jst)
Attachment #353745 - Flags: review+
Pushed changeset 8b659f81bab8 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Pushed changeset c6c8f99ca861 to mozilla-1.9.1.
Keywords: fixed1.9.1
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.