Decompiler fixes from bug 469625

VERIFIED FIXED in mozilla1.9.1b3

Status

()

Core
JavaScript Engine
P2
normal
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: brendan, Assigned: brendan)

Tracking

({testcase, verified1.9.1})

Trunk
mozilla1.9.1b3
testcase, verified1.9.1
Points:
---
Dependency tree / graph
Bug Flags:
wanted1.9.1 +
in-testsuite +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey, URL)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 353780 [details] [diff] [review]
patch

Split out here, with follow up fix for holey group assignment. Better bug hygiene for regression testing and blame won out of lazy hacker syndrome.

/be
Attachment #353780 - Flags: review+
Attachment #353780 - Flags: approval1.9.1?
Flags: wanted1.9.1?
(Assignee)

Comment 1

9 years ago
No holey group assignment bug, so no fix here. This is what jorendorff r+'ed.

/be
(Assignee)

Comment 2

9 years ago
(In reply to comment #1)
> No holey group assignment bug, so no fix here.

Oops, there is a holey group assignment bug, see bug 469625 comment 33. But it's a separate bug from this one. I'll file it shortly.

/be
Is this FIXED on trunk?
(Assignee)

Comment 4

9 years ago
Argh, this hasn't landed anywhere yet. I just landed it in tm:

http://hg.mozilla.org/tracemonkey/rev/d0e8862aa513

/be
Priority: -- → P2
Whiteboard: fixed-in-tracemonkey

Updated

9 years ago
Depends on: 471531
(Assignee)

Comment 5

9 years ago
Testcase is in bug 469625 comment 27.

/be
Flags: in-testsuite?

Updated

9 years ago
Attachment #353780 - Flags: approval1.9.1? → approval1.9.1+

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Keywords: testcase

Comment 6

9 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/348227af2565
Flags: wanted1.9.1? → wanted1.9.1+
Keywords: fixed1.9.1

Comment 7

9 years ago
testcases added bug 469625 comment 43
Flags: in-testsuite?
Flags: in-testsuite+
Flags: in-litmus-

Comment 8

9 years ago
js1_8/decompilation/regress-469625-01.js
v 1.9.1, 1.9.2
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.