Closed Bug 470392 Opened 11 years ago Closed 11 years ago

Update Thunderbird installer for Unicode support and locale verification

Categories

(Thunderbird :: Installer, defect)

x86
Windows Vista
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

Attachments

(2 files, 4 obsolete files)

Spinoff of bug 305039 for Thunderbird.
Attached patch patch for Unicode support rev1 (obsolete) — Splinter Review
Phil, is this going to require ifdefs?

I also cleaned up some of the code and made it so the survey can't be launched when uninstalling for Vista and above... this is due to the uninstaller always running elevated and there being no way to de-elevate in Vista.
Attachment #353791 - Flags: review?(philringnalda)
Attached patch patch for fixing up the locales (obsolete) — Splinter Review
Attachment #353792 - Flags: review?(philringnalda)
Comment on attachment 353791 [details] [diff] [review]
patch for Unicode support rev1

btw: the Unicode support patch requires the patch from bug 305039
Status: NEW → ASSIGNED
So far, I've been wrong every single time I say anything about 1.9.1 ifdefs, but I wouldn't think so, unless you're predicting a long and painful baking period. If I'm answering the right question, whether we can live with it landing on mozilla-central, burning the Windows comm-central+mozilla-central box for a couple of days (oh, it's already on fire!), then landing on 1.9.1 together with this patch, at which point everything greens up, I'd sure think so.

If I'm wrong, I can ifdef while I review tomorrow night: we've already gotten in your way too much lately :)
Attachment #353791 - Flags: review?(philringnalda)
Comment on attachment 353791 [details] [diff] [review]
patch for Unicode support rev1

Thanks Phil, I'm going to redistribute the two patches like I did for Seamonkey. Basically, some of the changes in the Unicode patch can be done in the locales patch and are just cleanup.

The Unicode portion is the part that would cause the comm-central / mozilla-central builds to burn so we should be ok as long as we don't have to bake long which we shouldn't.
Attachment #353792 - Flags: review?(philringnalda)
Holding off on review until I test this.
Attachment #353791 - Attachment is obsolete: true
Attachment #353792 - Attachment is obsolete: true
This patch can be checked in prior to the change to Unicode NSIS.
Attachment #354025 - Attachment is obsolete: true
Attachment #354026 - Flags: review?(philringnalda)
bah... I forgot to include the change to defines.nsi.in

Once again, this patch can be checked in prior to the change to Unicode NSIS.
Attachment #354026 - Attachment is obsolete: true
Attachment #354027 - Flags: review?(philringnalda)
Attachment #354026 - Flags: review?(philringnalda)
This patch requires the patch from bug 305039 and won't be pushed to comm-central until the patch from bug 305039 is pushed to mozilla-1.9.1
Attachment #354094 - Flags: review?(philringnalda)
Attachment #354027 - Flags: review?(philringnalda) → review+
Comment on attachment 354027 [details] [diff] [review]
patch for locale and general cleanup rev3 - checked in

r=me, thanks!

(Amazingly difficult to actually look at strings in the installer wizard, after thousands of times rushing through as fast as possible - I almost resorted to taking screenshots so I couldn't automatically click Next.)
Comment on attachment 354094 [details] [diff] [review]
patch for Unicode support rev2 (checked in)

I'm not going to pretend to actually understand it all, but it built a perfectly fine en-US installer for me, so Looks Good To Me :)
Attachment #354094 - Flags: review?(philringnalda) → review+
Comment on attachment 354027 [details] [diff] [review]
patch for locale and general cleanup rev3 - checked in

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/82c571b8e4b3
Attachment #354027 - Attachment description: patch for locale and general cleanup rev3 → patch for locale and general cleanup rev3 - checked in
Thanks Phil

Leaving open to land the patch for Unicode support after bug 305039 lands
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/7ae154a2a598
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
Attachment #354094 - Attachment description: patch for Unicode support rev2 → patch for Unicode support rev2 (checked in)
Summary: Update installer for Unicode support and locale verification → Update Thunderbird installer for Unicode support and locale verification
You need to log in before you can comment on or make changes to this bug.