470415 - mochitest does not allow ~ shortcut for --log-file argument

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[arno renevier]

Hi,
on devmo, there are examples of using --log-file with ~/mochitest.log argument:

python runtests.py --log-file=~/mochitest.log --file-level=DEBUG
https://developer.mozilla.org/en/Mochitest#Logging_results

Unfortunately, this won't work [1] because ~/mochitest.log is not expanded in python script.


[1]: Error: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileOutputStream.init]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: http://localhost:8888/tests/SimpleTest/MozillaFileLogger.js :: anonymous :: line 48"  data: no]

Comment 1

[(not currently active) Ted Mielczarek]

Should be easy to fix, just throw in an os.path.expanduser ( http://docs.python.org/library/os.path.html#os.path.expanduser ) here:
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py.in#336

Comment 2

[arno renevier]

Attachment: patch v1: expand options.logFile with os.path.expanduser

I used an intermediate variable to prevent having more than 80 characters on the line.

Comment 3

[(not currently active) Ted Mielczarek]

I'll push this.

Comment 4

[(not currently active) Ted Mielczarek]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/63719f0f1d85