470431 - Memory leak of document and content nodes with creating DOMMouseScroll event

Status: VERIFIED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, which leaks a document and content nodes according to the nspr log:
Results of processing log leak1.log :
Leaked document at address 3b72000.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/mw/Bureaublad/moz/firefox20081218/chrome/toolkit.jar!/content/global/bindings/scrollbar.xml".
 ... with URI "chrome://global/content/bindings/scrollbar.xml".
Leaked content nodes associated with node info manager at address 2c09cd0.
 ... with document URI "file:///C:/Documents%20and%20Settings/mw/Bureaublad/crashzone/ajaxdemolisher_files/mlk_dommousescroll.htm".
Leaked content nodes associated with node info manager at address 2c95e80.
 ... with document URI "jar:file:///C:/Documents%20and%20Settings/mw/Bureaublad/moz/firefox20081218/chrome/toolkit.jar!/content/global/bindings/scrollbar.xml".
 ... with document URI "chrome://global/content/bindings/scrollbar.xml".

Summary:
Leaked 0 out of 0 DOM Windows
Leaked 1 out of 51 documents
Leaked 0 out of 7 docshells
Leaked content nodes in 2 out of 63 documents

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Unfortunately nsDOMMouseScrollEvent needs to do the same thing what nsDOMMouseEvent ctor does.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 353838 [details] [diff] [review]
proposed patch

this is new code in 1.9.1 and should be fixed, IMO, before ff3.1

Comment 3

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20081220 Minefield/3.2a1pre

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 353838 [details] [diff] [review]
proposed patch

a191=beltzner

Comment 5

[Benjamin Smedberg]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6421be3f139d was the 1.9.1 checkin, for the record