Closed Bug 470452 Opened 11 years ago Closed 11 years ago

Update SeaMonkey installer for Unicode support and locale verification

Categories

(SeaMonkey :: Installer, defect)

x86
Windows Vista
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a2

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

Attachments

(2 files, 2 obsolete files)

Spinoff of bug 305039 for Seamonkey.

note: Bug 470392 is for Thunderbird.
Attached patch patch for fixing up the locales (obsolete) — Splinter Review
This patch isn't needed for implementing Unicode NSIS but it is IMO a nice to have. I also removed MUI_INNERTEXT_LICENSE_BOTTOM_RADIOBUTTONS since it isn't used.
Attachment #353856 - Flags: review?(bugzilla)
Comment on attachment 353856 [details] [diff] [review]
patch for fixing up the locales

Looks like a bit more needs to be done here for Seamonkey than other apps so removing review request
Attachment #353856 - Attachment is obsolete: true
Attachment #353856 - Flags: review?(bugzilla)
Also includes some additional cleanup
Attachment #353859 - Flags: review?(bugzilla)
Comment on attachment 353859 [details] [diff] [review]
patch for fixing up the locales rev2

Thanks for the patch. One line in override.properties needs fixing:
+SetupCaption=$BrandFullName Setup $(^Name)
Remove the $(^Name). r+ with that.
Attachment #353859 - Flags: review?(bugzilla) → review+
Thanks Frank... I forgot to remove that when testing the verification script.
Checked in to comm-central
http://hg.mozilla.org/comm-central/rev/4daac073741d

leaving open to land the patch for Unicode support after bug 305039 lands
Comment on attachment 353866 [details] [diff] [review]
patch for Unicode support rev1 (checked in)

Hey Frank, not sure if you missed this patch intentionally or not. We'll need this for the conversion to Unicode and I won't push it to comm-central until the patch from bug 305039 has been pushed to mozilla-1.9.1 which should happen a day or two after it is pushed to mozilla-central.
Comment on attachment 353866 [details] [diff] [review]
patch for Unicode support rev1 (checked in)

Did not forget about this patch :)
Attachment #353866 - Flags: review?(bugzilla) → review+
In this FIXED?
Oh, never mind.  :-)
Comment on attachment 353866 [details] [diff] [review]
patch for Unicode support rev1 (checked in)

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/306be9e163b0
Attachment #353866 - Attachment description: patch for Unicode support rev1 → patch for Unicode support rev1 (checked in)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0a2
Summary: Update installer for Unicode support and locale verification → Update SeaMonkey installer for Unicode support and locale verification
You need to log in before you can comment on or make changes to this bug.