Closed Bug 470455 Opened 11 years ago Closed 11 years ago

test_database_sync_embed_visits.js leaks

Categories

(Toolkit :: Places, defect)

x86
Windows 2000
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla1.9.2a1

People

(Reporter: sgautherie, Assigned: mak)

References

Details

(Keywords: fixed1.9.1, memory-leak)

Attachments

(1 file)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081219 Minefield/3.2a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/9410ad10c6f7)

This newly added test has the same(-looking) leak as bug 469062 had...
Summary: test_database_sync_embed_visits.js leaks now → test_database_sync_embed_visits.js leaks
yes, should be fixed with bug 469972.
it's not but that's my fault, apparently i did not attach latest version of the test, dunno why, sorry.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attached patch patch v1Splinter Review
remove a dump i had added while building the test, and fix finish
Attachment #353932 - Flags: review?(sdwilsh)
Target Milestone: --- → mozilla1.9.1
(In reply to comment #2)

I confirm that:
*Bug 469972 "v1.0" patch did not fix this.
*This is the only /toolkit/components/places/tests/sync/ test which calls do_test_finished() directly.
No longer depends on: 469972
(In reply to comment #4)
> (In reply to comment #2)
> 
> I confirm that:
> *Bug 469972 "v1.0" patch did not fix this.
> *This is the only /toolkit/components/places/tests/sync/ test which calls
> do_test_finished() directly.

both patches are needed to fix this
Depends on: 469972
Comment on attachment 353932 [details] [diff] [review]
patch v1

r=sdwilsh
Attachment #353932 - Flags: review?(sdwilsh) → review+
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081221 SeaMonkey/2.0a3pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/b839ff0630c6
 +http://hg.mozilla.org/comm-central/rev/2a4c4c1f0feb + bug 469606 patch)

Confirming with SeaMonkey.
http://hg.mozilla.org/mozilla-central/rev/7127f726f661
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1 → mozilla1.9.2a1
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081222 SeaMonkey/2.0a3pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/31dbaf4ca0c4
 +http://hg.mozilla.org/comm-central/rev/113540504a46 + bug 469606 patch)

V.Fixed
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Depends on: 469523
No longer depends on: 456414
You need to log in before you can comment on or make changes to this bug.