470455 - test_database_sync_embed_visits.js leaks

Status: VERIFIED FIXED

(Toolkit :: Places, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081219 Minefield/3.2a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/9410ad10c6f7)

This newly added test has the same(-looking) leak as bug 469062 had...

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

yes, should be fixed with bug 469972.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

it's not but that's my fault, apparently i did not attach latest version of the test, dunno why, sorry.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1

remove a dump i had added while building the test, and fix finish

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)

I confirm that:
*Bug 469972 "v1.0" patch did not fix this.
*This is the only /toolkit/components/places/tests/sync/ test which calls do_test_finished() directly.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to comment #4)
> (In reply to comment #2)
> 
> I confirm that:
> *Bug 469972 "v1.0" patch did not fix this.
> *This is the only /toolkit/components/places/tests/sync/ test which calls
> do_test_finished() directly.

both patches are needed to fix this

Comment 6

[Shawn Wilsher :sdwilsh]

Comment on attachment 353932 [details] [diff] [review]
patch v1

r=sdwilsh

Comment 7

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081221 SeaMonkey/2.0a3pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/b839ff0630c6
 +http://hg.mozilla.org/comm-central/rev/2a4c4c1f0feb + bug 469606 patch)

Confirming with SeaMonkey.

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/7127f726f661

Comment 9

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081222 SeaMonkey/2.0a3pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/31dbaf4ca0c4
 +http://hg.mozilla.org/comm-central/rev/113540504a46 + bug 469606 patch)

V.Fixed

Comment 10

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/72947483bbb2