Closed Bug 470592 Opened 16 years ago Closed 16 years ago

Messages no longer marked as read when hitting "Next Message" in an open message window

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 3.0b2

People

(Reporter: justdave, Assigned: mkmelin)

References

Details

(Keywords: regression)

Attachments

(1 file)

This is new behavior with:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20081220 Shredder/3.0b2pre

Sometime since 20081218 (which is the previous nightly I had).  This is quite likely a result of fixing the 'M' key so it actually worked in an open message window again, is my guess (because that also started working with this build).

Steps to reproduce:

Case 1:
1. Have a folder open that has several unread messages in it.
2. Double-click a message, or highlight it and press Enter, to open it in a standalone message window.
3. Observe that the message is now marked as Read in the folder summary panel (so far so good).
4. Hit 'N' or click the Next Message icon in the toolbar to go to the next message.
5. Observe that the message you just moved to is NOT marked as Read.  Hitting M while viewing the message properly marks it as Read though.

Case 2:
1. Have a folder open that has several unread messages in it.
2. Double-click a message, or highlight it and press Enter, to open it in a standalone message window.
3. Observe that the message is now marked as Read in the folder summary panel (so far so good).
4. Hit 'M' to mark the message as Unread again.
4. Hit 'N' or click the Next Message icon in the toolbar to go to the next message.
5. Observe that the message you just moved to IS marked as Read.
6. Hit 'N' again to go to the next message.
7. Observe that this message is ALSO marked as Read.

My takeaway from this is that the message we originally double-clicked to get it open in the new window is the one that keeps getting checked to see if the message has been marked read already or not before performing the action to do so automatically, even though the action is being performed on the correct message, it's not using the correct message to decide if it needs to be done or not.
Flags: blocking-thunderbird3.0b1?
Flags: blocking-thunderbird3.0b1? → blocking-thunderbird3?
Yes, your right - OnMsgLoaded always thinks it's the same message - and looking closely in the 3pane, the focus doesn't move. I'll have to check if it's from from bug 466925...
Flags: blocking-thunderbird3? → blocking-thunderbird3+
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.0b2
This regressed 2008-12-18 -> 2008-12-19
http://hg.mozilla.org/comm-central/pushloghtml?startdate=2008-12-18&enddate=2008-12-19+03%3A00%3A00

This is from bug 375381.

To test, mark a few messages as unread - then open the first one in the standalone window and move forward using F. BTW, i was wrong in comment 1, which message is selected shouldn't move in the 3pane.

Patch coming up.
Assignee: nobody → mkmelin+mozilla
Blocks: 375381
Status: NEW → ASSIGNED
Attached patch proposed fixSplinter Review
Put the function in the file it should be, and i don't think gTheadTree needs to be cached.
Attachment #354193 - Flags: superreview?(bienvenu)
Attachment #354193 - Flags: review?(bienvenu)
Comment on attachment 354193 [details] [diff] [review]
proposed fix

thx, Magnus.
Attachment #354193 - Flags: superreview?(bienvenu)
Attachment #354193 - Flags: superreview+
Attachment #354193 - Flags: review?(bienvenu)
Attachment #354193 - Flags: review+
changeset:   1486:113540504a46
http://hg.mozilla.org/comm-central/rev/113540504a46
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20081224 Shredder/3.0b2pre ID:20081224025847

Magnus, while doing the steps in comment 0 the selection of the thread pane isn't moved to the actually displayed message but stays at the one you have double-clicked. Is there already a bug filed about? I can only find one for Penelope which is bug 464337. Isn't it a core issue?
Status: RESOLVED → VERIFIED
(In reply to comment #6)
> Magnus, while doing the steps in comment 0 the selection of the thread pane
> isn't moved to the actually displayed message but stays at the one you have
> double-clicked. Is there already a bug filed about? I can only find one for
> Penelope which is bug 464337. Isn't it a core issue?

That's been like that forever, so it's definitely a separate bug.  I've complained about that periodically in the past, but probably never got around to filing a bug about it.  I am a former Eudora user from many years ago, and Eudora did move the selection in the summary window as you stepped through the messages, so that explains Penelope having a bug about it.  That bug probably ought to be made more generic instead of being specific to Penelope. :)
You need to log in before you can comment on or make changes to this bug.