browser/locales Makefile refers to bookmarks.inc which does not exist for en-GB - build failure

RESOLVED FIXED

Status

()

--
major
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: tg.mufcnotforsale, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20081220 Shiretoko/3.1b3pre
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-GB; rv:1.9.1b3pre) Gecko/20081220 Shiretoko/3.1b3pre

Assuming due to bug 461979 bookmarks.inc does not exist in locale en-GB and therefore a en-GB locale build of b3pre from repo fails. Have the translators been made aware this is required or as mentioned in the above bug will a script be used to generate the file?

%/defaults/profile/bookmarks.html: bookmarks.inc generic/profile/bookmarks.html.in
        $(SYSINSTALL) -D $(dir $@)
        $(PYTHON) $(topsrcdir)/config/Preprocessor.py \
          -I $< \
          -DAB_CD=$(NO_JA_JP_MAC_AB_CD) \
          $(srcdir)/generic/profile/bookmarks.html.in \
          > $@


Reproducible: Always

Steps to Reproduce:
1. Clone mozilla-1.9.1 releases repo
2. Clone l10n-mozilla-1.9.1/en-GB repo
3. Run build with locale set to en-GB
Actual Results:  
make[5]: *** No rule to make target `../../dist/bin/defaults/profile/bookmarks.html', needed by `libs'. Stop.
make[5]: Leaving directory `/home/tom/development/mozilla/191src/firefox-static-en-GB/browser/locales'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/home/tom/development/mozilla/191src/firefox-static-en-GB/browser'
make[3]: *** [libs_tier_app] Error 2
make[3]: Leaving directory `/home/tom/development/mozilla/191src/firefox-static-en-GB'
make[2]: *** [tier_app] Error 2
make[2]: Leaving directory `/home/tom/development/mozilla/191src/firefox-static-en-GB'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/home/tom/development/mozilla/191src/firefox-static-en-GB'
make: *** [build] Error 2

Expected Results:  
Build should be successful.
(Reporter)

Comment 1

10 years ago
Created attachment 354036 [details]
Example mozconfig to produce failure
(Reporter)

Updated

10 years ago
Status: UNCONFIRMED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.