470671 - Thunderbird l10n linux nightly following wrong mozilla tree

Status: VERIFIED FIXED

(Mozilla Messaging Graveyard :: Server Operations, defect, P1)

Description

[Stefan Plewako [:stef]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.0.5) Gecko/2008122108 Firefox/3.0.5 Flock/2.0.3
Build Identifier: 

At least since 2008.12.18 linux comm-central l10n thunderbird nightly builds are following mozilla-central instead mozilla-1.9.1 which results in busted builds (missing file) for "green" locales, lack of testing packages for our qa teams and is generally wrong/bad.

Please fix that ASAP.

Reproducible: Always

Comment 1

[Mark Banner (:standard8)]

Moving this to the right component, cc'ing our build engineer to take a look.

Axel - could this be an issue with not having resolved bug 468108?

Comment 2

[Axel Hecht [:Pike]]

No, this is a problem of the source steps which don't ensure to catch up with branch changes.

My guess is that client.py is stuck on a branch for the linux builder.

Comment 3

[Axel Hecht [:Pike]]

This doesn't block the infra bug 470669, IMHO.

Comment 4

[Mark Banner (:standard8)]

ok, I see it: http://build.mozillamessaging.com/buildbot/production/builders/Linux%20comm-central%20l10n/builds/2296/steps/shell/logs/stdio (from http://build.mozillamessaging.com/buildbot/production/builders/Linux%20comm-central%20l10n/builds/2296)

comm-central is on the right branch, but for some reason, client.py has decided to pull mozilla-central rather than comm-central. Definitely needs gozer to fix this.

Comment 5

[Philippe M. Chiasson (:gozer)]

Attachment: Tweak the regular expression used to detect mozilla-central

Turns out the regular expression used to detect wether mozilla/ is a clone of mozilla-central needed a little tweak. It expected the pull url to end with a '/',
which is actually optionnal.

Comment 6

[Philippe M. Chiasson (:gozer)]

comparing with http://hg.mozilla.org/comm-central
searching for changes
changeset:   1482:cf1802da787c
tag:         tip
user:        Philippe M. Chiasson <[e-mail]>
date:        Mon Dec 22 11:33:05 2008 -0500
summary:     Bug 470671. Fix client.py's incorrect detection of mozilla-central clone when missing a trailing '/'. r=Standard8

Comment 7

[Stefan Plewako [:stef]]

v, thx!

Comment 8

[[e-mail]]

(In reply to comment #5)
> It expected the pull url to end with a '/', which is actually optional.
But preferred. Not noticed the "real url" warnings?

Comment 9

[Philippe M. Chiasson (:gozer)]

If you meant this:

pulling from http://hg.mozilla.org//index.cgi/comm-central
real URL is http://hg.mozilla.org/comm-central

I'd say it's not much of a warning, and it doesn't even include a trailing '/'