470672 - Don't upload l10n nightly builds with status other then success to ftp

Status: RESOLVED WONTFIX

(Thunderbird :: General, defect)

Description

[Stefan Plewako [:stef]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.0.5) Gecko/2008122108 Firefox/3.0.5 Flock/2.0.3
Build Identifier: 

Filling for Thunderbird only since I don't know if this affects also Firefox (needs verification) and others.

We shouldn't public any l10n builds with status other then success (green) on ftp (eg we are doing this for orange/testfailed builds).

Reproducible: Always

Comment 1

[Simon Paquet [:sipaq]]

I don't agree with this. Orange l10n builds mostly mean, that the locale has translated all the strings, but still has some cleanup work to do for obsolete strings and files.

I wouldn't want to exclude a locale, whose only fault it is to still have some obsolete strings in their tree.

Comment 2

[Stefan Plewako [:stef]]

(In reply to comment #1)
> Orange l10n builds mostly mean, that the locale has
> translated all the strings, but still has some cleanup work to do for obsolete
> strings and files.

If mostly don't mean absolutely always then we need some other status - and currently afaik it don't means.

Comment 3

[Mark Banner (:standard8)]

Does Firefox do this at the moment? Is there a relevant Firefox bug here? Generally we follow the Firefox lead on the build environment.

Comment 4

[Stefan Plewako [:stef]]

Don't know if this is true for Firefox/bug number.

Comment 5

[Axel Hecht [:Pike]]

I guess that "success" here is a matter of definition.

https://wiki.mozilla.org/User:AxelHecht/L10n_build_deliverables is my point of view, in which nightlies are actually l10n-merged, which would recover from the general errors.

I do agree that on real build errors, there shouldn't be an upload, and there are probably errors from which we can't or shouldn't recover.

I would be surprised if this was actually happening now, as tb builds likely don't run compare-locales or other checks for further error conditions, so I'm marking this depending on bug 470673.

Comment 6

[Mark Banner (:standard8)]

Doing l10n merge & uploading will be a much better solution than fixing this bug. I've morphed bug 470673 into implementing l10n merge, so therefore we don't need this bug.