Closed
Bug 470708
Opened 17 years ago
Closed 17 years ago
addressingwidget appears as sunken, again
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: mnyromyr, Assigned: mnyromyr)
Details
(Keywords: fixed1.9.1, regression)
Attachments
(1 file)
|
820 bytes,
patch
|
Gavin
:
review+
shaver
:
approval1.9.1+
|
Details | Diff | Splinter Review |
This is a Linux trunk regression, although not recent.
When bug 398874 ported bug 184811 to toolkit, it defined the border colours for .menulist-compact, but overlooked that the gnomestripe menulist rule does not define a border width anymore...
Hence the border colours aren't visible.
As a reminder:
Although defined in Toolkit these styles aren't used by Firefox itself, only by Seamonkey's and Thunderbird's mail composer in native theming.
Attachment #354093 -
Flags: review?(gavin.sharp)
| Assignee | ||
Updated•17 years ago
|
Assignee: nobody → mnyromyr
Updated•17 years ago
|
Attachment #354093 -
Flags: review?(gavin.sharp) → review+
| Assignee | ||
Comment 1•17 years ago
|
||
Comment on attachment 354093 [details] [diff] [review]
add missing border width
Requesting a191 for this one-liner, since this rule is NOT used by Firefox, but is inside a file which is...
Attachment #354093 -
Flags: approval1.9.1?
Updated•17 years ago
|
Component: XUL Widgets → Themes
QA Contact: xul.widgets → themes
Comment 2•17 years ago
|
||
Land this on trunk?
| Assignee | ||
Comment 3•17 years ago
|
||
Landed <http://hg.mozilla.org/mozilla-central/rev/2326e07bb2a7> on trunk.
| Assignee | ||
Comment 4•17 years ago
|
||
Now that it did bake for almost two weeks, marking it as fixed so we could get it into 1.9.x finally?
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Target Milestone: --- → mozilla1.9.2a1
Updated•17 years ago
|
Attachment #354093 -
Flags: approval1.9.1? → approval1.9.1+
Comment 5•17 years ago
|
||
Comment on attachment 354093 [details] [diff] [review]
add missing border width
a=shaver
| Assignee | ||
Comment 6•17 years ago
|
||
Landed <http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3039e605daa6> on 1.9.1.
Updated•17 years ago
|
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•