1.9.0 l10n buildslaves lose track of CVSROOT

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: coop, Assigned: coop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
After a fresh checkout, the Mac and Linux l10n buildslaves on the 1.9.0 branch (fx-mac-1.9-slave2 and fx-linux-1.9-slave2) will build happily for several cycles before they suddenly start throwing this error:

cvs checkout: existing repository /cvsroot/CVSROOT/Emptydir does not match /cvsroot/mozilla
cvs checkout: ignoring module mozilla/client.mk

I'm unsure what's causing this yet. The CVSROOT is coming from the config file, so it *should* be either always working or always not.

The complete command that is failing is:

cvs -q -z3 -d :ext:cltbld@cvs.mozilla.org:/cvsroot co mozilla/client.mk mozilla/nsprpub mozilla/other-licenses/7zstub/firefox

From casual testing, it appears that updating the client.mk file on its own works fine, so splitting this step into two parts seems like a logical solution.
(Assignee)

Updated

9 years ago
Priority: -- → P2

Comment 1

9 years ago
I have found that in the L10nMixin when initiaized:
http://mxr.mozilla.org/mozilla/source/tools/buildbotcustom/l10n/scheduler.py#42
there is never an initialization of self.cvsRoot in the __init__ function and the default value is probably meaningless since on the function NightlyL10n the cvsRoot is already initialized to None and therefore it stays with that value (if not mistaken)

I wish I had used kwargs properly depending if repoType was "cvs" or "hg" instead of optional parameters
(Assignee)

Comment 2

9 years ago
(In reply to comment #1)
> there is never an initialization of self.cvsRoot in the __init__ function and
> the default value is probably meaningless since on the function NightlyL10n the
> cvsRoot is already initialized to None and therefore it stays with that value
> (if not mistaken)

I've added a "self.cvsRoot = cvsRoot" to the __init__ section, and I've restarted the master.
(Assignee)

Comment 3

9 years ago
Created attachment 354249 [details] [diff] [review]
Update client.mk on its own.

Simply setting cvsRoot didn't help.

It appears we hit the above error when mozilla/client.mk actually has updates pending. By splitting the cvs into two parts and updating client.mk before the other modules, we avoid the error.
Attachment #354249 - Flags: review?(armenzg)

Updated

9 years ago
Attachment #354249 - Flags: review?(armenzg) → review+
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.