The default bug view has changed. See this FAQ.

SpiderMonkey long long emulation (JSLL stuff in jslong.h) is no longer necessary

RESOLVED FIXED in mozilla7

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: jimb, Assigned: Waldo)

Tracking

unspecified
mozilla7
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
js/src/jslong.h defines a bunch of macros named JSLL_* that define an abstraction for working with 64-bit values that works even when the compiler doesn't provide a 64-bit long long type.  We don't support such targets any more, so this code should be removed, and the macro uses replaced with code that uses int64_t and uint64_t directly.

We need something like bug 465640, so that we can use {,u}int64_t with impunity.

Updated

8 years ago
Flags: in-testsuite-
Flags: in-litmus-
Created attachment 538149 [details] [diff] [review]
Rewrite all JSLL_* macro users, remove jslong.h and all its #includes

The JSLL_* macros make the PRMJ_Now code unreadable enough that I'm translating it in one patch, then rearranging it to be readable in a second.
Assignee: general → jwalden+bmo
Status: NEW → ASSIGNED
Attachment #538149 - Flags: review?(jimb)
Created attachment 538150 [details] [diff] [review]
Adjust PRMJ_Now to be readable
Attachment #538150 - Flags: review?(jimb)
(Reporter)

Comment 3

6 years ago
Comment on attachment 538149 [details] [diff] [review]
Rewrite all JSLL_* macro users, remove jslong.h and all its #includes

Review of attachment 538149 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #538149 - Flags: review?(jimb) → review+
(Reporter)

Comment 4

6 years ago
Comment on attachment 538150 [details] [diff] [review]
Adjust PRMJ_Now to be readable

Review of attachment 538150 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #538150 - Flags: review?(jimb) → review+
I butted my head against that JSLL stuff, once.  Good riddance!
(In reply to comment #5)
> I butted my head against that JSLL stuff, once.  Good riddance!

It was from a long time ago, in a galaxy far, far away...

(Windows 3.1 with a 16-bit C/C++ compiler Microsoft had stopped supporting in 1995, which crashed randomly until you reordered declarations just right; Mac PowerPlant; ancient GCC, from the EGCS fork days and even earlier...)

/be
http://hg.mozilla.org/tracemonkey/rev/5da430ecfdd7
Whiteboard: fixed-in-tracemonkey
Target Milestone: --- → mozilla7
and http://hg.mozilla.org/tracemonkey/rev/159fedddb24c
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/5da430ecfdd7
http://hg.mozilla.org/mozilla-central/rev/159fedddb24c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.