Closed Bug 470792 Opened 11 years ago Closed 11 years ago

help.xul has a wrapper vbox that prevents the toolbar to be unified

Categories

(SeaMonkey :: Help Viewer, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: stefanh, Assigned: stefanh)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

toolkit/themes/pinstripe/global/toolbar.css:
------------------------------------------------
.toolbar-primary,
window > toolbox:nth-of-type(1) > toolbar:nth-of-type(1) {
-moz-appearance: -moz-mac-unified-toolbar;
}


help.xul:
------------------------------------------------
  <vbox flex="1">
    <toolbox id="help-toolbox" class="toolbox-top">
      <toolbar id="HelpToolbar" class="chromeclass-toolbar" chromedir="&locale.dir;">

I could be wrong, but I can't see any reason for the vbox.
I figured it would be bad of me to re-indent everything, but I can of course do it if you think it's better.
Attachment #354197 - Flags: review?(neil)
Status: NEW → ASSIGNED
Comment on attachment 354197 [details] [diff] [review]
Remove vbox wrapper

>   <stringbundle id="bundle_viewZoom"/>
>   <stringbundle id="findBundle"
>                 src="chrome://global/locale/finddialog.properties"/>
>   <stringbundle id="bundle_help"
>                 src="chrome://help/locale/help.properties"/>
>-
I don't think it makes sense to remove this blank line as it delmits the nonpresentational elements above from the presentational elements below.

>       </vbox>
>     </hbox>
>-  </vbox>
> </window>
Replacing the close tag with a blank line would at least preserve the nice "slope" effect ;-)
Attachment #354197 - Flags: review?(neil) → review+
Pushed changeset 314c9e78f9e1 (with comment #2 addressed) to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Pushed changeset b56fb0f3033c to releases/mozilla-1.9.1.
Keywords: fixed1.9.1
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.