Remove deprecated macros that are no longer in use

RESOLVED FIXED in mozilla1.9.1b3

Status

()

Toolkit
NSIS Installer
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.1b3
x86
Windows Vista
fixed1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Several of the macros that have been deprecated no longer have callers and should be removed
Specifically
createComponentsINI
createShortcutsINI
createBasicCustomOptionsINI
createBasicCompleteCustomOptionsINI
createBasicCustomSetAsDefaultOptionsINI
createSummaryINI
un.createUnConfirmINI
GetPathFromRegStr
Also GetParentDir
Created attachment 354204 [details] [diff] [review]
patch rev1
Attachment #354204 - Flags: review?(jmathies)

Updated

10 years ago
Attachment #354204 - Flags: review?(jmathies) → review+
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/068efdff925f
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Attachment #354204 - Flags: approval1.9.1?
Comment on attachment 354204 [details] [diff] [review]
patch rev1

Drivers, I'd like this for 1.9.1 since I finally removed all callers of these macros and I would hate to have one creep back in.
Comment on attachment 354204 [details] [diff] [review]
patch rev1

a191=beltzner
Attachment #354204 - Flags: approval1.9.1? → approval1.9.1+
pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f5c2c70c6bb4
Keywords: fixed1.9.1
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b3
You need to log in before you can comment on or make changes to this bug.