Closed Bug 470799 Opened 16 years ago Closed 16 years ago

Remove deprecated macros that are no longer in use

Categories

(Firefox :: Installer, defect)

Product:
Firefox
Component:
Installer
Platform:
x86
Windows Vista
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b3

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

patch rev1
20.37 KB, patch
jimm
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
Several of the macros that have been deprecated no longer have callers and should be removed
Specifically createComponentsINI createShortcutsINI createBasicCustomOptionsINI createBasicCompleteCustomOptionsINI createBasicCustomSetAsDefaultOptionsINI createSummaryINI un.createUnConfirmINI GetPathFromRegStr
Also GetParentDir
Attached patch patch rev1 — — Splinter Review
Attachment #354204 - Flags: review?(jmathies)
Attachment #354204 - Flags: review?(jmathies) → review+
Pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/068efdff925f
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Attachment #354204 - Flags: approval1.9.1?
Comment on attachment 354204 [details] [diff] [review] patch rev1 Drivers, I'd like this for 1.9.1 since I finally removed all callers of these macros and I would hate to have one creep back in.
Comment on attachment 354204 [details] [diff] [review] patch rev1 a191=beltzner
Attachment #354204 - Flags: approval1.9.1? → approval1.9.1+
pushed to mozilla-1.9.1 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f5c2c70c6bb4
Keywords: fixed1.9.1
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b3
Component: NSIS Installer → Installer
Product: Toolkit → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: