Closed
Bug 470850
Opened 16 years ago
Closed 15 years ago
Add IMAP nsIMsgFolderListener tests
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: rain1, Assigned: rain1)
References
Details
Attachments
(1 file, 2 obsolete files)
39.80 KB,
patch
|
rain1
:
review+
|
Details | Diff | Splinter Review |
The IMAP story is significantly more complicated than the one for local messages as far as nsIMsgFolderListener goes, so it'll be a good idea to add some tests here. I've been having some issues with the fakeserver, so this is all that I could get working reliably. A lot of the patch is conversion from UNIX to DOS line endings, so as to not trip up an assertion or two in the IMAP parsing code. I'll add more tests as I get them working.
Assignee | ||
Comment 1•15 years ago
|
||
I was seeing lots of warnings in the log, so I worked around a few apparent problems.
Attachment #354236 -
Attachment is obsolete: true
Attachment #355020 -
Flags: review?(bugzilla)
Comment 2•15 years ago
|
||
Comment on attachment 355020 [details] [diff] [review] Same tests, now with less warnings >diff --git a/mailnews/base/test/unit/test_nsIMsgFolderListenerIMAP.js b/mailnews/base/test/unit/test_nsIMsgFolderListenerIMAP.js I think I would prefer this test in mailnews/imap/test/unit. Although it is semi-testing the nsIMsgFolderListener interfaces, what it is really testing is the imap backend (then you won't have to import the head file as well).
Attachment #355020 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 3•15 years ago
|
||
(In reply to comment #2) > (From update of attachment 355020 [details] [diff] [review]) > >diff --git a/mailnews/base/test/unit/test_nsIMsgFolderListenerIMAP.js b/mailnews/base/test/unit/test_nsIMsgFolderListenerIMAP.js > > I think I would prefer this test in mailnews/imap/test/unit. Although it is > semi-testing the nsIMsgFolderListener interfaces, what it is really testing is > the imap backend (then you won't have to import the head file as well). Yeah, I think I agree.
Attachment #355020 -
Attachment is obsolete: true
Attachment #355738 -
Flags: review+
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Comment 4•15 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/051ba12d4303
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
Comment 5•15 years ago
|
||
Also checked in the additional line ending changes: http://hg.mozilla.org/comm-central/rev/53325b008d61
You need to log in
before you can comment on or make changes to this bug.
Description
•