Closed Bug 470859 Opened 13 years ago Closed 13 years ago

nsIDKey key(aClass) stealing cpu cycles from nsComponentManagerImpl::GetService()

Categories

(Core :: XPCOM, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

References

()

Details

(Keywords: fixed1.9.1, perf, Whiteboard: [fixed1.9.1b3])

Attachments

(1 file, 1 obsolete file)

Attached patch nuke line (obsolete) — Splinter Review
Seems to be a leftover, deleting it makes func 5x faster.
Attachment #354247 - Flags: review?(benjamin)
Blocks: 459117
Attachment #354247 - Flags: review?(benjamin) → review+
Looks like RegisterComponentCommon has the same unused variable?
Keywords: checkin-needed
Right ! They are the only two in the whole code.
Assignee: nobody → tglek
Status: NEW → ASSIGNED
Flags: in-testsuite-
OS: Linux → All
Hardware: x86 → All
Whiteboard: [c-n: wait for comment 2 !?]
Version: unspecified → Trunk
Alright, here is a patch that nukes 2 lines
Attachment #354431 - Flags: review?(benjamin)
Blocks: 471087
Keywords: perf
Attachment #354431 - Flags: review?(benjamin)
Attachment #354431 - Flags: review+
Attachment #354431 - Flags: approval1.9.1+
Whiteboard: [c-n: wait for comment 2 !?]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: blocking1.9.1?
Resolution: --- → FIXED
Attachment #354247 - Attachment is obsolete: true
Whiteboard: [c-n: baking for 1.9.1]
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
Priority: -- → P1
Comment on attachment 354431 [details] [diff] [review]
nuke 2 lines
[Checkin: Comment 4 & 5]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f0a2af343dc1
Attachment #354431 - Attachment description: nuke 2 lines → nuke 2 lines [Checkin: Comment 4 & 5]
Whiteboard: [c-n: baking for 1.9.1]
Target Milestone: --- → mozilla1.9.2a1
Whiteboard: [fixed1.9.1b3]
You need to log in before you can comment on or make changes to this bug.