Closed
Bug 470859
Opened 16 years ago
Closed 16 years ago
nsIDKey key(aClass) stealing cpu cycles from nsComponentManagerImpl::GetService()
Categories
(Core :: XPCOM, defect, P1)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
()
Details
(Keywords: fixed1.9.1, perf, Whiteboard: [fixed1.9.1b3])
Attachments
(1 file, 1 obsolete file)
|
634 bytes,
patch
|
benjamin
:
review+
benjamin
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Seems to be a leftover, deleting it makes func 5x faster.
Attachment #354247 -
Flags: review?(benjamin)
|
||
Updated•16 years ago
|
Attachment #354247 -
Flags: review?(benjamin) → review+
|
||
Comment 1•16 years ago
|
||
Looks like RegisterComponentCommon has the same unused variable?
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 2•16 years ago
|
||
Right ! They are the only two in the whole code.
Assignee: nobody → tglek
Status: NEW → ASSIGNED
Flags: in-testsuite-
OS: Linux → All
Hardware: x86 → All
Whiteboard: [c-n: wait for comment 2 !?]
Version: unspecified → Trunk
|
|
Assignee | |
Comment 3•16 years ago
|
||
Alright, here is a patch that nukes 2 lines
Attachment #354431 -
Flags: review?(benjamin)
|
|
||
Updated•16 years ago
|
Attachment #354431 -
Flags: review?(benjamin)
Attachment #354431 -
Flags: review+
Attachment #354431 -
Flags: approval1.9.1+
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [c-n: wait for comment 2 !?]
|
|
Assignee | |
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: blocking1.9.1?
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•16 years ago
|
||
pushed http://hg.mozilla.org/mozilla-central/rev/1f8dd6dd9e20
|
|
||
Updated•16 years ago
|
Attachment #354247 -
Attachment is obsolete: true
|
|
||
Updated•16 years ago
|
Whiteboard: [c-n: baking for 1.9.1]
|
|
||
Updated•15 years ago
|
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
Priority: -- → P1
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 354431 [details] [diff] [review] nuke 2 lines [Checkin: Comment 4 & 5] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f0a2af343dc1
Attachment #354431 -
Attachment description: nuke 2 lines → nuke 2 lines
[Checkin: Comment 4 & 5]
|
|
||
Updated•15 years ago
|
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [c-n: baking for 1.9.1]
Target Milestone: --- → mozilla1.9.2a1
|
|
||
Updated•15 years ago
|
Whiteboard: [fixed1.9.1b3]
You need to log in
before you can comment on or make changes to this bug.
Description
•