Closed Bug 470875 Opened 17 years ago Closed 17 years ago

Update Flashblock XBL to 1.5.7.1

Categories

(Camino Graveyard :: Annoyance Blocking, defect)

Product:
Camino Graveyard
Component:
Annoyance Blocking
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED WORKSFORME

People

(Reporter: philip.chee, Unassigned)

Details

In Flashblock 1.5.7 I introduced a regression by replacing the deprecated Components.lookupMethod Components.utils.lookupMethod. However this caused Flashblock to break on trunk due to increased security restrictions. See Bug 469844 and Bug 467659. Please upgrade the flashblock.xml in Camino to 1.5.7.1 /or/ just search and replace s/Components\.utils\.lookupMethod/Components\.lookupMethod/g Apologies for breaking Flashblock.
Philip, those restrictions are only on 1.9.1 and newer, or is there a testcase where we should see a Flashblock failure on 1.9.0 and/or 1.8.1? Not that we shouldn't sync to the latest supported Flashblock at least on 1.9.0...it's just I haven't noticed any failures.
There were two instances of Components.lookupMethod. I only changed one of them in Flasblock 1.5.7 which is why I didn't spot the problem earlier in my limited tests. I see that the latest 1.9.0.x is also affected if I use C.u.lookupMethod: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6pre) Gecko/2008121006 GranParadiso/3.0.6pre Error: Permission denied to get property XPCComponents.utils Source file: chrome://flashblock/content/flashblock.xml Line: 17
Hmm, from what I can tell, it looks like that bug only existed in -unstable (you made the change on 4 December), and our last Flashblock upgrade was to 1.5.7 stable on 19 Nov.
That is, Flashblock 1.5.7.1 is equivalent to Flashblock 1.5.7, at least as far as flashblock/content/flashblock.xml is concerned.
Hmm. Right. I forgot the timing. Sorry for the bugspam.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → VERIFIED
Thanks for the heads-up nevertheless :)
You need to log in before you can comment on or make changes to this bug.