470881 - Enable major update test for nightly Fx3.1 builds

Status: VERIFIED FIXED

(Release Engineering :: General, defect, P3)

Description

[Robert Strong (they/them - no direct email)]

I'd like the update type for Beta 3 to be major so the major update code path is exercised prior to the 3.1 release since a significant amount of the update code changed.

Comment 1

[[e-mail] (:bhearsum)]

As in the past we'll be doing a fake major update or two before the real thing - do you still feel we need to do Beta 3 give this?

Comment 2

[[e-mail] (:bhearsum)]

Er, "Need to do Beta 3 on the Major update path"

Comment 3

[Robert Strong (they/them - no direct email)]

The fake major update has in the past been done very close to the actual release and is not seen by a large amount of people. It being done very close to release doesn't give us much time to fix any bugs found which can prevent us from having the time to fix any bugs found and with it not being seen by a large amount of users can prevent us from finding bugs that only apply to the major update path. Another option would be to do this for a couple of nightly builds.

Comment 4

[juan becerra [:juanb]]

Maybe we can get a set of major updates from 3.0.5 to 3.1b2, before and if we decide to do this, just to check if there are big and obvious problems before we send these to beta users. See bug 459878.

Comment 5

[Robert Strong (they/them - no direct email)]

Sure, if we can do this with the nightly or beta users.

Comment 6

[[e-mail] (:bhearsum)]

To be clear, I don't think it's a big deal on our side to do 3.1b3 as a major update I just wanted to make sure it was necessary. In fact, it's probably easier to do that than 3.0.5 -> 3.1b2.

Comment 7

[Robert Strong (they/them - no direct email)]

note: the changes I'd like to have tested were made in bug 324121 and would need to be tested by either nightly users or a beta 2 to beta 3 update.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Switch nightly snippets to var=value style

AUS can read two styles of update snippet [1] and we're using the old, plain style for nightly updates. This patch moves us over to use the var=value style which is also used for releases.

[1] http://mxr.mozilla.org/mozilla/source/webtools/aus/xml/inc/patch.class.php#147

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: example hackery to enable a major update test

... which lets us to this sort of thing pretty trivially as a temporary change(the old snippet style doesn't support major updates). SOME_URL would be replaced by a link to a page explaining the rationale of the test and how to file bugs. We could similarly add a license URL if that needs testing too.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 357761 [details] [diff] [review]
Switch nightly snippets to var=value style

Checked in and prometheus-vm:/builds/nightly-partial-generation/app updated. Going to run a Fx2.0.0.x linux nightly to confirm this doesn't break anything.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Rob, could you come up with some content for the major update, which points people to the right place to file bugs or whatever feedback mechanism you want. Let us know the URL and we can enable this for mozilla-1.9.1 updates. Same goes for a license url if you'd like that too.

Will extensionVersion also need to be set to something ? Dunno if you need that to force a check with AMO, or what the consequences of setting it for nightly testers are.

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #10)
> Going to run a Fx2.0.0.x linux nightly to confirm this doesn't break anything.

This worked fine.

Comment 13

[Robert Strong (they/them - no direct email)]

(In reply to comment #11)
> Rob, could you come up with some content for the major update, which points
> people to the right place to file bugs or whatever feedback mechanism you want.
> Let us know the URL and we can enable this for mozilla-1.9.1 updates. Same goes
> for a license url if you'd like that too.
I've asked beltzner for guidance as to where the page can live or will you be able to take care of adding the page?

I'll put together some content for the test.

No need for a license url.

> Will extensionVersion also need to be set to something ? Dunno if you need that
> to force a check with AMO, or what the consequences of setting it for nightly
> testers are.
extensionVersion should always be for nightly, beta, release, etc. the app version... it was a bad name choice way back when.

Are you going to do this for the beta or nightly users? Nightly users tend to notice incorrect behavior since they tend to update often and a good portion check the forums so it is easy to communicate with them.

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

I've been assuming 3.1b3pre --> 3.1b3pre on the nightly channel, is that OK ?

I can put the html (for the update offer pane) up on ftp.m.o if you'd like; just attach it here.

Comment 15

[Robert Strong (they/them - no direct email)]

Attachment: screenshot of billboard

Hey beltzner, can I get you to review the billboard for the test? Thanks

Comment 16

[Robert Strong (they/them - no direct email)]

Attachment: html for billboard

This is the html used for the billboard based off of http://www.mozilla.com/en-US/firefox/3.0/details/index.html

The path should be something along the lines of www.mozilla.com/en-US/firefox/3.1/details/update_test.html

Comment 17

[Robert Strong (they/them - no direct email)]

Comment on attachment 358037 [details]
screenshot of billboard

Note: the billboard is the only portion of the ui to pay attention to in the review... the Firefox 4.0 text is due to my custom update snippet

Comment 18

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 358037 [details]
screenshot of billboard

I think we want to make it really clear to testers - who are more likely to recognize and be surprised by a major update dialog - that this is a test. I would suggest:

title: This is a test!
subhead: This is not a real major version update, just a test.
extra: Problems? File a _bug_ or _tell us_.

_bug_ should go to bugzilla
_tell_us_ should go to the firefox.feedback.prerelease google group

Comment 19

[Reed Loden [:reed]]

(In reply to comment #18)
> _tell_us_ should go to the firefox.feedback.prerelease google group

Hendrix, right?

Comment 20

[Robert Strong (they/them - no direct email)]

Attachment: billboard screenshot rev2

Comment 21

[Robert Strong (they/them - no direct email)]

Attachment: html for billboard rev2

Comment 22

[Robert Strong (they/them - no direct email)]

Comment on attachment 358077 [details]
html for billboard rev2

Nick, I got a verbal on the billboard html from beltzner.

(In reply to comment #14)
> I've been assuming 3.1b3pre --> 3.1b3pre on the nightly channel, is that OK ?
That's perfect

> I can put the html (for the update offer pane) up on ftp.m.o if you'd like;
> just attach it here.
Thanks

Comment 23

[Reed Loden [:reed]]

(In reply to comment #22)
> > I can put the html (for the update offer pane) up on ftp.m.o if you'd like;
> > just attach it here.
> Thanks

Why? Can't we put this on www.mozilla.com?

Comment 24

[Robert Strong (they/them - no direct email)]

Nick, can we put this at
www.mozilla.com/en-US/firefox/3.1/details/update_test.html

so it picks up the css files?

Comment 25

[Nick Thomas [:nthomas] (UTC+12)]

I suggested ftp.m.o because I can quickly adjust the content there, and I thought this was going to be a short term test and not worth jumping through all the process for mozilla.com. But I don't mind where it lives.

Comment 26

[Nick Thomas [:nthomas] (UTC+12)]

How's this ?

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/experimental/bug470881/update_test.html

Just added a base tag to the <head> of attachment 358077 [details].

Comment 27

[Robert Strong (they/them - no direct email)]

Attachment: screenshot using base

Using base isn't working likely due to the restrictions placed on the content in the ui. :(

Comment 28

[Nick Thomas [:nthomas] (UTC+12)]

And now ?

Comment 29

[Robert Strong (they/them - no direct email)]

It works now that they are next to the html... Thanks!

Comment 30

[Robert Strong (they/them - no direct email)]

btw: this will test the major update code paths for the 3.1 -> future scenario in case it isn't clear.

Comment 31

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Enable major mode for mozilla-1.9.1 updates

Going to apply this to the nightly-update generation system ahead of the 24/Jan nightlies.

Comment 32

[Robert Strong (they/them - no direct email)]

Posted to the forums (including the Shiretoko nightly thread) so we should be good to go:
http://forums.mozillazine.org/viewtopic.php?t=1058875

Comment 33

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 358347 [details] [diff] [review]
Enable major mode for mozilla-1.9.1 updates

This is applied as a local mod on the nightly update generator. Today's nightlies (20090124...) for Fx3.1b3pre will use major update mode.

Comment 34

[Nick Thomas [:nthomas] (UTC+12)]

Removing dep on bug 459878, since we're testing a 3.1 -> 3.2 equivalent.

Comment 35

[Nick Thomas [:nthomas] (UTC+12)]

Seems to be working fine, let me know when you're ready to turn it off Rob.

Comment 36

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Display issues of MU dialog

At least on OS X some glitches can be seen:

* unnecessary vertical scrollbar
* no padding before the HTML title at the top
* gray background for the problems box?

Comment 37

[Robert Strong (they/them - no direct email)]

The scrollbar has been a problem on Mac OS X for while now... bug 374820.

Not sure what is going on with the html... I used the same styling as used by the 2.0.0.x to 3.0.x major update. It should be fixable when the major update billboard is created.

Comment 38

[[e-mail] (:bhearsum)]

Out of curiosity, are we going to turn this off at any point?

Comment 39

[Nick Thomas [:nthomas] (UTC+12)]

The second part of the test is the version transition from 3.1b3pre to 3.1pre, so it's also blocked by b3.

Comment 40

[Robert Strong (they/them - no direct email)]

Just a note... Shredder just went to 3.0b3pre from 3.0b2pre and the minor update version bump worked properly for me (e.g. only add-ons that are no longer compatible and don't have a compatibility update showed up in the app update add-on incompatibility list).

Comment 41

[Robert Strong (they/them - no direct email)]

(In reply to comment #35)
> Seems to be working fine, let me know when you're ready to turn it off Rob.
Thanks Nick... the nightly updates can go back to being minor updates.

Comment 42

[Nick Thomas [:nthomas] (UTC+12)]

I've removed attachment 358347 [details] [diff] [review] from the partial generator, so Shiretoko will go back to minor updates.

Comment 43

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified. Minor updates are served again.

Comment 44

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Very nice to have this peace of mind, thanks!