Enable major update test for nightly Fx3.1 builds

VERIFIED FIXED

Status

P3
normal
VERIFIED FIXED
10 years ago
5 years ago

People

(Reporter: rstrong, Assigned: nthomas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments, 2 obsolete attachments)

I'd like the update type for Beta 3 to be major so the major update code path is exercised prior to the 3.1 release since a significant amount of the update code changed.
As in the past we'll be doing a fake major update or two before the real thing - do you still feel we need to do Beta 3 give this?
Er, "Need to do Beta 3 on the Major update path"
The fake major update has in the past been done very close to the actual release and is not seen by a large amount of people. It being done very close to release doesn't give us much time to fix any bugs found which can prevent us from having the time to fix any bugs found and with it not being seen by a large amount of users can prevent us from finding bugs that only apply to the major update path. Another option would be to do this for a couple of nightly builds.

Comment 4

10 years ago
Maybe we can get a set of major updates from 3.0.5 to 3.1b2, before and if we decide to do this, just to check if there are big and obvious problems before we send these to beta users. See bug 459878.
Depends on: 459878
Sure, if we can do this with the nightly or beta users.
To be clear, I don't think it's a big deal on our side to do 3.1b3 as a major update I just wanted to make sure it was necessary. In fact, it's probably easier to do that than 3.0.5 -> 3.1b2.
Summary: Specify major for the Beta 3 update snippet → Specify major update for the Firefox 3.1Beta 3 update snippets
Assignee: nobody → nthomas
Priority: -- → P3
note: the changes I'd like to have tested were made in bug 324121 and would need to be tested by either nightly users or a beta 2 to beta 3 update.
(Assignee)

Comment 8

10 years ago
Created attachment 357761 [details] [diff] [review]
Switch nightly snippets to var=value style

AUS can read two styles of update snippet [1] and we're using the old, plain style for nightly updates. This patch moves us over to use the var=value style which is also used for releases.

[1] http://mxr.mozilla.org/mozilla/source/webtools/aus/xml/inc/patch.class.php#147
Attachment #357761 - Flags: review?(bhearsum)
(Assignee)

Comment 9

10 years ago
Created attachment 357762 [details] [diff] [review]
example hackery to enable a major update test

... which lets us to this sort of thing pretty trivially as a temporary change(the old snippet style doesn't support major updates). SOME_URL would be replaced by a link to a page explaining the rationale of the test and how to file bugs. We could similarly add a license URL if that needs testing too.
Attachment #357761 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 10

10 years ago
Comment on attachment 357761 [details] [diff] [review]
Switch nightly snippets to var=value style

Checked in and prometheus-vm:/builds/nightly-partial-generation/app updated. Going to run a Fx2.0.0.x linux nightly to confirm this doesn't break anything.
Attachment #357761 - Flags: checked‑in+ checked‑in+
(Assignee)

Comment 11

10 years ago
Rob, could you come up with some content for the major update, which points people to the right place to file bugs or whatever feedback mechanism you want. Let us know the URL and we can enable this for mozilla-1.9.1 updates. Same goes for a license url if you'd like that too.

Will extensionVersion also need to be set to something ? Dunno if you need that to force a check with AMO, or what the consequences of setting it for nightly testers are.
Status: NEW → ASSIGNED
Priority: P3 → P2
Summary: Specify major update for the Firefox 3.1Beta 3 update snippets → Enable major update test for nightly Fx3.1 builds
(Assignee)

Comment 12

10 years ago
(In reply to comment #10)
> Going to run a Fx2.0.0.x linux nightly to confirm this doesn't break anything.

This worked fine.
Whiteboard: waiting on info
(In reply to comment #11)
> Rob, could you come up with some content for the major update, which points
> people to the right place to file bugs or whatever feedback mechanism you want.
> Let us know the URL and we can enable this for mozilla-1.9.1 updates. Same goes
> for a license url if you'd like that too.
I've asked beltzner for guidance as to where the page can live or will you be able to take care of adding the page?

I'll put together some content for the test.

No need for a license url.

> Will extensionVersion also need to be set to something ? Dunno if you need that
> to force a check with AMO, or what the consequences of setting it for nightly
> testers are.
extensionVersion should always be for nightly, beta, release, etc. the app version... it was a bad name choice way back when.

Are you going to do this for the beta or nightly users? Nightly users tend to notice incorrect behavior since they tend to update often and a good portion check the forums so it is easy to communicate with them.
(Assignee)

Comment 14

10 years ago
I've been assuming 3.1b3pre --> 3.1b3pre on the nightly channel, is that OK ?

I can put the html (for the update offer pane) up on ftp.m.o if you'd like; just attach it here.
Created attachment 358037 [details]
screenshot of billboard

Hey beltzner, can I get you to review the billboard for the test? Thanks
Attachment #358037 - Flags: review?(beltzner)
Created attachment 358039 [details]
html for billboard

This is the html used for the billboard based off of http://www.mozilla.com/en-US/firefox/3.0/details/index.html

The path should be something along the lines of www.mozilla.com/en-US/firefox/3.1/details/update_test.html
Comment on attachment 358037 [details]
screenshot of billboard

Note: the billboard is the only portion of the ui to pay attention to in the review... the Firefox 4.0 text is due to my custom update snippet
Comment on attachment 358037 [details]
screenshot of billboard

I think we want to make it really clear to testers - who are more likely to recognize and be surprised by a major update dialog - that this is a test. I would suggest:

title: This is a test!
subhead: This is not a real major version update, just a test.
extra: Problems? File a _bug_ or _tell us_.

_bug_ should go to bugzilla
_tell_us_ should go to the firefox.feedback.prerelease google group
Attachment #358037 - Flags: review?(beltzner) → review-
(In reply to comment #18)
> _tell_us_ should go to the firefox.feedback.prerelease google group

Hendrix, right?
Created attachment 358076 [details]
billboard screenshot rev2
Created attachment 358077 [details]
html for billboard rev2
Attachment #358037 - Attachment is obsolete: true
Attachment #358039 - Attachment is obsolete: true
Comment on attachment 358077 [details]
html for billboard rev2

Nick, I got a verbal on the billboard html from beltzner.

(In reply to comment #14)
> I've been assuming 3.1b3pre --> 3.1b3pre on the nightly channel, is that OK ?
That's perfect

> I can put the html (for the update offer pane) up on ftp.m.o if you'd like;
> just attach it here.
Thanks
Attachment #358077 - Flags: review+
(In reply to comment #22)
> > I can put the html (for the update offer pane) up on ftp.m.o if you'd like;
> > just attach it here.
> Thanks

Why? Can't we put this on www.mozilla.com?
Nick, can we put this at
www.mozilla.com/en-US/firefox/3.1/details/update_test.html

so it picks up the css files?
(Assignee)

Comment 25

10 years ago
I suggested ftp.m.o because I can quickly adjust the content there, and I thought this was going to be a short term test and not worth jumping through all the process for mozilla.com. But I don't mind where it lives.
(Assignee)

Comment 26

10 years ago
How's this ?

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/experimental/bug470881/update_test.html

Just added a base tag to the <head> of attachment 358077 [details].
Whiteboard: waiting on info
Created attachment 358342 [details]
screenshot using base

Using base isn't working likely due to the restrictions placed on the content in the ui. :(
(Assignee)

Comment 28

10 years ago
And now ?
It works now that they are next to the html... Thanks!
btw: this will test the major update code paths for the 3.1 -> future scenario in case it isn't clear.
(Assignee)

Comment 31

10 years ago
Created attachment 358347 [details] [diff] [review]
Enable major mode for mozilla-1.9.1 updates

Going to apply this to the nightly-update generation system ahead of the 24/Jan nightlies.
Posted to the forums (including the Shiretoko nightly thread) so we should be good to go:
http://forums.mozillazine.org/viewtopic.php?t=1058875
(Assignee)

Updated

10 years ago
Depends on: 475105
(Assignee)

Comment 33

10 years ago
Comment on attachment 358347 [details] [diff] [review]
Enable major mode for mozilla-1.9.1 updates

This is applied as a local mod on the nightly update generator. Today's nightlies (20090124...) for Fx3.1b3pre will use major update mode.
(Assignee)

Comment 34

10 years ago
Removing dep on bug 459878, since we're testing a 3.1 -> 3.2 equivalent.
No longer depends on: 459878
(Assignee)

Comment 35

10 years ago
Seems to be working fine, let me know when you're ready to turn it off Rob.
Priority: P2 → P3
Whiteboard: waiting to disable test
Created attachment 358700 [details]
Display issues of MU dialog

At least on OS X some glitches can be seen:

* unnecessary vertical scrollbar
* no padding before the HTML title at the top
* gray background for the problems box?
The scrollbar has been a problem on Mac OS X for while now... bug 374820.

Not sure what is going on with the html... I used the same styling as used by the 2.0.0.x to 3.0.x major update. It should be fixable when the major update billboard is created.
Out of curiosity, are we going to turn this off at any point?
(Assignee)

Comment 39

10 years ago
The second part of the test is the version transition from 3.1b3pre to 3.1pre, so it's also blocked by b3.
Whiteboard: waiting to disable test → test running until 3.1pre version bump + a few days
Just a note... Shredder just went to 3.0b3pre from 3.0b2pre and the minor update version bump worked properly for me (e.g. only add-ons that are no longer compatible and don't have a compatibility update showed up in the app update add-on incompatibility list).
(In reply to comment #35)
> Seems to be working fine, let me know when you're ready to turn it off Rob.
Thanks Nick... the nightly updates can go back to being minor updates.
(Assignee)

Comment 42

10 years ago
I've removed attachment 358347 [details] [diff] [review] from the partial generator, so Shiretoko will go back to minor updates.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: test running until 3.1pre version bump + a few days
Verified. Minor updates are served again.
Status: RESOLVED → VERIFIED
Very nice to have this peace of mind, thanks!
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.