47092 - Logic Error in pref-fonts.js

Status: VERIFIED WORKSFORME

(SeaMonkey :: Preferences, defect, P3)

Description

[Jens]

pref-fonts.js, function selectLanguage:

The fetching of the fixed/var font sizes is inside a block
  if (selectedItem)
whereas selectedItem refers to the selected font.
This does not make sense because the font size is not bound to 
the selected font name.
The lines
  var sizeVarVal = parent.hPrefWindow.pref.GetIntPref(...);
  var sizeFixedVal = parent.hPrefWindow.pref.GetIntPref(...);
are totally independend of the selected font.

Comment 1

[Henri Sivonen (:hsivonen)]

*** Bug 47091 has been marked as a duplicate of this bug. ***

Comment 2

[Henri Sivonen (:hsivonen)]

*** Bug 47090 has been marked as a duplicate of this bug. ***

Comment 3

[Gervase Markham [:gerv]]

Confirming for evaluation by matt (last person to check in to that file.)

Gerv

Comment 4

[sairuh (rarely reading bugmail)]

->jbetak, or...?

is this still an issue?

Comment 5

[[e-mail] (away - not reading bugmail)]

sairuh:
thanks, fine with me.

Jens:
could you please validate your findings against the latest Mozilla trunk build 
or alternatively against the online source repository index?

http://lxr.mozilla.org/seamonkey/source/xpfe/components/prefwindow/resources/con
tent/pref-fonts.js

I'm copying the relevant lines below. I worked on some bugfixes in this area 
and there is a handful of other people in the Mozilla organization, who could 
address your concerns equally well, if not better. I'd just like to thank you 
for your contribution and do some preliminary checks before we proceed further 
and possibly get more people involved.

var variableSizePref = "font.size.variable." + languageList.value;
var fixedSizePref = "font.size.fixed." + languageList.value;

var sizeVarVal = parent.hPrefWindow.pref.GetIntPref( variableSizePref );
var sizeFixedVal = parent.hPrefWindow.pref.GetIntPref( fixedSizePref );

Comment 6

[[e-mail] (away - not reading bugmail)]

oh, I just noticed that this bug was file on July 31, 2000. The pref-fonts.js 
code has been reworked by several people since then I can't see anything 
resembling Jens' description of the "flawed logic". We store font sizes on a 
per-language-group basis.

This might have been an issue with 6.0RTM - marking worksforme. Jens, if you 
are still reading bugmail, it would be nice, if you confirmed this.

Comment 7

[Jens]

verified

Comment 8

[[e-mail] (away - not reading bugmail)]

Jens - thanks for verifying this!