47096 - Browser localizable acceskeys fix

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P3)

Description

[Andrea]

Hi,
I'm Andrea, an Italian localizer.

I've found some accesskeys in the navigator chrome are not localizable.
I'm gonna sending you the fixed chrome files whom -in the source tree-
live in:

Seamonkey/xpfe/browser/resources/locale/en-US/navigator.dtd
Seamonkey/xpfe/browser/resources/content/navigatorOverlay.dtd

I've tested the modified files works in build 2000-07-25-21.
The changes affect (as you may suspect) only some accesskeys. To be sure
no further modifications occurred in these files since build
2000-07-25-21, I'm gonna report to you the diffs from the original
files.

navigatorOverlay.xul (4 lines changed from the hardcoded values to the
references in navigator.dtd)
-------------
187c187
<   <menu id="menu_View" accesskey="&viewMenu.accesskey;"
value="&viewMenu.label;">
---
>   <menu id="menu_View" accesskey="v" value="&viewMenu.label;">
343c343
<   <menu accesskey="&searchMenu.accesskey;" value="&searchMenu.label;">

---
>   <menu accesskey="s" value="&searchMenu.label;">
403c403
<   <menu accesskey="&debugMenu.accesskey;" value="&debugMenu.label;">
---
>   <menu accesskey="d" value="&debugMenu.label;">
480c480
<   <menu accesskey="&QA.accesskey;" value="&QA.label;">
---
>   <menu accesskey="q" value="&QA.label;">

navigator.dtd (4 lines added)
-------------
45d44
< <!ENTITY viewMenu.accesskey "v">
123d121
< <!ENTITY searchMenu.accesskey "s">
192d189
< <!ENTITY debugMenu.accesskey "d">
276d272
< <!ENTITY QA.accesskey "q">

Please also note that in navigator.dtd is present the 'buildId.label'
entity. In the files attached with this mail this entity is set to
2000072521. I think there should be some kind of mechanism in the build
process who automatically changes this value, so overwriting should have
no side effects, but since I'm not sure of this, please take it in
consideration.

Tao Chen ( mailto:tao@netscape ) has proposed himself as contact to
review my changes.

I hope you can accept my small changes. If I've done something wrong
please let me know.

Thanks.

Comment 1

[Andrea]

Attachment: Browser en-US strings including the new acceskeys

Comment 2

[Andrea]

Attachment: navigatorOverlay.xul with the accesskeys fixed

Comment 3

[Andrea]

Please Tao, Vidur asked for a review to check-in these changes. You can find the 
2 modified files attached to this bug (navigator.dtd + navigatorOverlay.xul)_

Sorry for all this spam (can't be done all in a single step ?)

Thanks.

Comment 4

[tao]

The patch looks ok to me.

Comment 5

[Gervase Markham [:gerv]]

Confirming to get on vidur's radar; adding patch keyword (although the fix is a 
new copy of the file rather than a patch.)

Vidur - can you work out what has been done, and check in the fix? r=tao ...

Gerv

Comment 6

[tao]

navigatorOverlya.xul (r.121) contains the fix already. Please verify.

Comment 7

[Andrea]

Since the bug has been fixed and verified I'm closing this bug :)