470997 - TM: trace-test.js should throw an error when |test.jitstats| contains an unrecognized property name

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

A number of the tests added in bug 470137 incorrectly include jitstats expectations in the form of a "sideExits" property.  This is an invalid name; the correct one is "sideExitIntoInterpreter".  This error would have been caught if trace-test.js were to abort when unrecognized names are detected; we should add such a detection mechanism.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Comment 2

[Jeff Walden [:Waldo]]

Typos begone!

http://hg.mozilla.org/tracemonkey/rev/d0a0f0694ced

This would have pointed out bug 470214 immediately, rather than by happenstance; no effect on the build, a win for test-writing when your fingers slip.

Comment 3

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/d0a0f0694ced

Comment 4

[Jeff Walden [:Waldo]]

I followed up with http://hg.mozilla.org/tracemonkey/rev/1dd1af3aec3e to unbreak trace-test.js when run in a build without a tracemonkey global property (where jitstats aren't available and where jitstatHandler bails before doing any callbacks).

Comment 5

[Bob Clary [:bc] (inactive)]

these changes already synced with js1_8_1/trace/trace-test.js

Comment 6

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d612c9619585