Closed Bug 470997 Opened 11 years ago Closed 11 years ago

TM: trace-test.js should throw an error when |test.jitstats| contains an unrecognized property name

Categories

(Core :: JavaScript Engine, defect, major)

defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: Waldo, Assigned: Waldo)

References

Details

(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

A number of the tests added in bug 470137 incorrectly include jitstats expectations in the form of a "sideExits" property.  This is an invalid name; the correct one is "sideExitIntoInterpreter".  This error would have been caught if trace-test.js were to abort when unrecognized names are detected; we should add such a detection mechanism.
Depends on: 471214
Attached patch PatchSplinter Review
Attachment #356638 - Flags: review?(gal)
Attachment #356638 - Flags: review?(gal) → review+
Typos begone!

http://hg.mozilla.org/tracemonkey/rev/d0a0f0694ced

This would have pointed out bug 470214 immediately, rather than by happenstance; no effect on the build, a win for test-writing when your fingers slip.
Flags: wanted1.9.1?
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/d0a0f0694ced
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: wanted1.9.1? → wanted1.9.1+
Resolution: --- → FIXED
I followed up with http://hg.mozilla.org/tracemonkey/rev/1dd1af3aec3e to unbreak trace-test.js when run in a build without a tracemonkey global property (where jitstats aren't available and where jitstatHandler bails before doing any callbacks).
these changes already synced with js1_8_1/trace/trace-test.js
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.