Closed Bug 471044 Opened 13 years ago Closed 13 years ago

Assertion failure: (tc->flags & TCF_IN_FUNCTION) || (tc->parseContext->callerFrame && tc->parseContext->callerFrame->fun && tc->parseContext->callerFrame->varobj == tc->u.scopeChain)

Categories

(Core :: JavaScript Engine, defect)

Other Branch
x86
All
defect
Not set
blocker

Tracking

()

VERIFIED FIXED

People

(Reporter: bc, Assigned: igor)

References

Details

(5 keywords, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

In tracemonkey repo:

Assertion failure: (tc->flags & TCF_IN_FUNCTION) || (tc->parseContext->callerFrame && tc->parseContext->callerFrame->fun && tc->parseContext->callerFrame->varobj == tc->u.scopeChain), at ../jsemit.cpp:2043

happens on many tests (e.g. e4x/Expressions/11.1.4-08.js) in the shell without jit enabled.

http://hg.mozilla.org/tracemonkey/rev/09997a70e4fb Bug 470758 re=gressed this.

So many tests fail with this assert that it makes testing tracemonkey impossible.
Flags: in-testsuite+
Flags: in-litmus-
Attached patch fix v1Splinter Review
The fix moves the check TCF_IN_FOR_INIT right before upvar lookup. Without this the for-names for scripts are processed as name inside function.
Assignee: general → igor
Status: NEW → ASSIGNED
Attachment #354392 - Flags: review?(mrbkap)
Comment on attachment 354392 [details] [diff] [review]
fix v1

Sorry.
Attachment #354392 - Flags: review?(mrbkap) → review+
pushed to tm -- http://hg.mozilla.org/tracemonkey/rev/edd031c8937c
Whiteboard: fixed-in-tracemonkey
merged to mc
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: wanted1.9.1+
v 1.9.1, 1.9.2
Status: RESOLVED → VERIFIED
Depends on: 474005
You need to log in before you can comment on or make changes to this bug.