471106 - impossible to move imported bookmarks into different collection

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Marc]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en; rv:1.9.0.6pre) Gecko/2008121820 Camino/2.0b1 (like Firefox/3.0.6pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en; rv:1.9.0.6pre) Gecko/2008121820 Camino/2.0b1 (like Firefox/3.0.6pre)

I have import my firefox bookmarks and I cannot move them in the Bookmark Bar/Menu. I tried import with a file, exactly the same problem... I tried too a drag and drop from the firefox Bookmarks but only the first element was import...

Reproducible: Always

Steps to Reproduce:
1. Import firefox bookmarks
2. try to move the import bookmarks Menu Bar
3.
Actual Results:  
nothing go in the Camino Bookmarks Menu Bar

Expected Results:  
move Bookmarks

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If you click on "Imported Firefox Bookmarks" in the left-hand pane of the bookmark manager, then click in the right-hand pane and select all (Cmd-A), and then drag all the highlighted bookmarks to the "Bookmark Menu" or "Bookmark Bar" items back in the left-hand pane, do the bookmarks end up where you want them?

Comment 2

[Marc]

Nothing are moved...

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Do you see any messages from Camino in the console.log (accessed via /Applications/Utilities/Console.app) when you try to move the bookmarks?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Never mind, I see this, too (and no, no console messages).

You can move the "Imported foo Bookmarks" folder elsewhere, but you cannot move any of the contents out of the "Imported foo Bookmarks" folder. You also can't copy bookmarks (Cmd-C or via drag). 

I'm not positive, but this may be related to the HTML bookmarks importer; I don't see this bug with Safari (or Opera), but I do with Firefox, iCab 3, SeaMonkey….

This works in 1.6.6 and doesn't work in 2.0b1; beyond that, I don't know where it regressed.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Yep, works in 2008-09-04-00, fails in 2008-09-05-00

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=Camino&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-09-04+00%3A00&maxdate=2008-09-05+00%3A00&cvsroot=%2Fcvsroot

There are other bugs, but the only one touching bookmarks is bug 439024.

Comment 6

[Stuart Morgan]

Attachment: fix

The move I was doing to shim the new import style into the old loop wasn't correct (it ended up destroying the parents of the top-level bookmarks, which is why they wouldn't move). Rather than fix it, I removed it entirely and put the shim higher up, to start moving the caller closer to the form it will eventually have when I reorganize the other bookmark importers.

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 354540 [details] [diff] [review]
fix

rs=pink

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.