Closed Bug 471179 Opened 16 years ago Closed 14 years ago

Implement PR_GetPhysicalMemorySize for NetBSD

Categories

(NSPR :: NSPR, defect)

x86
NetBSD
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: martin, Assigned: tnn)

Details

Attachments

(1 file, 2 obsolete files)

There is no existing implementation of PR_GetPhysicalMem() for NetBSD. This patch adds one.
Assignee: wtc → martin
Status: NEW → ASSIGNED
Attached patch updated patch (obsolete) — Splinter Review
Updated patch against mozilla-central. No code change, just reduces patch fuzz.
We've had it in the NetBSD packages collection for several years without problems.
Please review and commit it.
Thank you!
Attachment #448360 - Flags: review?(hskupin)
Attachment #354485 - Attachment is obsolete: true
Assignee: martin → tnn
Comment on attachment 448360 [details] [diff] [review]
updated patch

Tobias, I'm not a code reviewer. I stepped in to help you to find the right person. I believe Wan-Teh is the right person here to request review from.
Attachment #448360 - Flags: review?(hskupin) → review?(wtc)
Comment on attachment 448360 [details] [diff] [review]
updated patch

r=nelson  Will commit later, probably this weekend.

Have you got any other patches to NSPR that are languishing due to no review request?  If so, please mark them with review requests.  You may ask either Wan-Teh or me for review.
Attachment #448360 - Flags: review+
> You may ask either Wan-Teh or me for review.
You may also ask Ted Mielczarek <ted.mielczarek@gmail.com>
I made some whitespace changes and checked in the patch
on the NSPR trunk (NSPR 4.8.5).

Checking in prsystem.c;
/cvsroot/mozilla/nsprpub/pr/src/misc/prsystem.c,v  <--  prsystem.c
new revision: 3.34; previous revision: 3.33
done

This patch is apparently based on the similar code
in PR_GetNumberOfProcessors, so we should be able
to use the code on all the platforms for which
_PR_HAVE_SYSCTL is defined.  But I'm not sure if
all of them supports HW_PHYSMEM64.
Attachment #448360 - Attachment is obsolete: true
Attachment #448360 - Flags: review?(wtc)
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Summary: Implement PR_GetPhysicalMem for NetBSD → Implement PR_GetPhysicalMemorySize for NetBSD
Target Milestone: --- → 4.8.5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: