471201 - Re-push incorrectly sandboxed add-ons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

From bug 470203, all public add-ons that have been updated since r20493 have had all their versions sandboxed.  We need to go through all the versions that were public before and make them public again.

This should be fixed after bug 471200.

Comment 2

[Michael Morgan [:morgamic]]

Fred - can you take a look at this?  Let me know if you need help.

Comment 3

[Fred Wenzel [:wenzel]]

I identified 49 candidates possibly affected by this bug. I listed all add-ons that are public themselves but have no versions that contain any public files. So not all of these add-ons have necessarily been affected by this bug, but they should be a subset of the following list:

"39";"Mouse Gestures Redox"
"130";"708090"
"131";"708090-lite"
"517";"ChatZilla fr-FR"
"825";"Edit Config Files"
"1422";"Compact Menu - Firebird"
"1652";"Minimeter"
"1754";NULL
"2103";"Shortcut Toolbar"
"2183";"YaCybar"
"2231";"Skype Sidebar"
"2288";"Restart Thunderbird"
"2476";"Metal Lion - iCe"
"2484";"Metal Lion - Brushed iCe"
"2697";"CrossFTP"
"3050";"EarlyBlue"
"3051";"LCARStrek"
"3502";"Auto USPS Customs Forms"
"3649";"Flash Switcher (win)"
"3694";"Resizeable Form Fields"
"3700";"Enjoy Browser"
"3721";"Metal Lion - Brushed iCe Chrome"
"3722";"Compact Menu - Blue"
"3726";"Tab Overflow Scrollbar"
"3776";"FireColour"
"3828";"Aluminium Kai 2"
"3914";"These Toolbars with Small Icon"
"3958";"LinkCounter"
"3959";"ImageCounter"
"4174";"eDictX(Vietnamese Dictionary Extension)"
"4303";"Soldatenweb QuickLink and Chat-Status"
"4325";"Metal Lion - Vista"
"4442";"Mega Man 2"
"4534";"MultiSidebar"
"4547";"The Kidnapped Bear"
"4555";"SCM"
"4585";NULL
"4626";"Metal Lion - Vista"
"4762";"Hide Menubar"
"4857";"14ZKidz"
"4864";"delete"
"4927";NULL
"5701";"Metal Lion - 300"
"6205";"System Proxy"
"6236";NULL
"7051";"Metal Lion - Andromeda"
"7203";"HeadingsMap"
"8040";"Simply Blue"
"8957";NULL

Comment 4

[Dave Garrett]

(In reply to comment #3)
> I listed all add-ons that are public themselves but have no versions
> that contain any public files.

While that list could be used to fix the really broken ones, many add-ons affected by this had their most recent version pushed public and/or put out a new one after the fix. None of the examples in bug 470203 are in that list. (AutoPager, VertTabbar, Tab Kit, & Flagfox) Is there some way you can search for all public add-ons with no public versions posted before the day r20493 was pushed?

Comment 5

[Fred Wenzel [:wenzel]]

Good call. I'll make a new list considering this. (Now I only have to figure out when that was pushed ;))

Comment 6

[Fred Wenzel [:wenzel]]

All right, the new list has 75 items for all add-ons that are public themselves but have no public files that were pushed public before the time stamp of the push -- which I assumed to be the time stamp of bug 471200 comment 1. Here's the new list:

39; Mouse Gestures Redox
130; 708090
131; 708090-lite
517; ChatZilla fr-FR
570; SEOpen
825; Edit Config Files
1422; Compact Menu - Firebird
1652; Minimeter
1754; NULL
2103; Shortcut Toolbar
2183; YaCybar
2231; Skype Sidebar
2288; Restart Thunderbird
2476; Metal Lion - iCe
2484; Metal Lion - Brushed iCe
2697; CrossFTP
3050; EarlyBlue
3051; LCARStrek
3502; Auto USPS Customs Forms
3649; Flash Switcher (win)
3694; Resizeable Form Fields
3700; Enjoy Browser
3721; Metal Lion - Brushed iCe Chrome
3722; Compact Menu - Blue
3726; Tab Overflow Scrollbar
3776; FireColour
3828; Aluminium Kai 2
3914; These Toolbars with Small Icon
3958; LinkCounter
3959; ImageCounter
4174; eDictX(Vietnamese Dictionary Extension)
4303; Soldatenweb QuickLink and Chat-Status
4325; Metal Lion - Vista
4442; Mega Man 2
4534; MultiSidebar
4547; The Kidnapped Bear
4555; SCM
4585; NULL
4626; Metal Lion - Vista
4762; Hide Menubar
4857; 14ZKidz
4864; delete
4927; NULL
5701; Metal Lion - 300
6205; System Proxy
6236; NULL
6444; Minimonth/Calendars Splitter
6629; Professor Ratings
6763; NULL
6886; Hide Find Bar
6965; Default FullZoom Level
6979; RCSearch
7051; Metal Lion - Andromeda
7203; HeadingsMap
7518; Firefox PDF Plugin for Mac OS X
7560; Gmail Ad blocker
7657; eBay Toolbar
7757; Blank Canvas Gmail Signatures
8040; Simply Blue
8063; Badongo Bar
8239; avant.garde.10011 :rosa:
8442; FacePAD: Facebook Photo Album Downloader
8542; LastPass Password Manager (beta)
8691; Firefox Ad Killer
8830; tang
8879; FoxTab
8957; NULL
9009; buySAFE Shopping Advisor
9396; Orbit classic 2008
9858; MushroomKingdom
9943; Search Cloudlet for Google and Yahoo
9980; SKY plus!
9998; LumiNight
10000; xSidebar for Thunderbird
10184; Orange Cool

Comment 7

[Fred Wenzel [:wenzel]]

(In reply to comment #4)
> None of the examples in bug 470203 are in that list.

None of them is in the new list either -- but I take it they've been fixed before?

Comment 8

[Fred Wenzel [:wenzel]]

I fixed them all by hand (so much fun), as follows:

39; all but the latest version (expecting review) made public
130; empty add-on shell. Disabled.
131; empty add-on shell. Disabled.
517; all but the latest version (expecting review) made public
570; all versions made public.
825; empty add-on shell. Disabled.
1422; empty add-on shell. Disabled.
1652; all but the latest version (expecting review) made public
1754; empty add-on shell. Disabled.
2103; all but the latest version (expecting review) made public
2183; empty add-on shell. Disabled.
2231; empty add-on shell. Disabled.
2288; empty add-on shell. Disabled.
2476; empty add-on shell. Disabled.
2484; empty add-on shell. Disabled.
2697; all versions made public.
3050; all but the latest version (expecting review) made public
3051; all but the latest version (expecting review) made public
3502; all but the latest version (expecting review) made public
3649; empty add-on shell. Disabled.
3694; empty add-on shell. Disabled.
3700; empty add-on shell. Disabled.
3721; empty add-on shell. Disabled.
3722; empty add-on shell. Disabled.
3726; empty add-on shell. Disabled.
3776; all but the latest version (expecting review) made public
3828; empty add-on shell. Disabled.
3914; empty add-on shell. Disabled.
3958; empty add-on shell. Disabled.
3959; empty add-on shell. Disabled.
4174; empty add-on shell. Disabled.
4303; Single file, awaiting review -> marked sandboxed, pending review.
4325; empty add-on shell. Disabled.
4442; empty add-on shell. Disabled.
4534; all but the latest version (expecting review) made public
4547; empty add-on shell. Disabled.
4555; empty add-on shell. Disabled.
4585; empty add-on shell. Disabled.
4626; empty add-on shell. Disabled.
4762; all but the latest version (expecting review) made public
4857; empty add-on shell. Disabled.
4864; empty add-on shell. Disabled.
4927; empty add-on shell. Disabled.
5701; empty add-on shell. Disabled.
6205; empty add-on shell. Disabled.
6236; empty add-on shell. Disabled.
6444; all versions made public.
6629; all versions made public.
6763; all versions made public.
6886; all versions made public.
6965; all versions made public.
6979; all versions made public.
7051; empty add-on shell. Disabled.
7203; all but the latest version (expecting review) made public
7518; all versions made public.
7560; all versions made public.
7657; all versions made public.
7757; all versions made public.
8040; empty add-on shell. Disabled.
8063; all versions made public.
8239; all versions made public.
8442; all versions made public.
8542; all but the latest version (expecting review) made public
8691; all versions made public.
8830; all versions made public.
8879; all versions made public.
8957; empty add-on shell. Disabled.
9009; all but the latest version (expecting review) made public
9396; all versions made public.
9858; all versions made public.
9943; all but the latest version (expecting review) made public
9980; all but the latest version (expecting review) made public
9998; No change necessary.
10000; No change necessary.
10184; No change necessary.

Marking this fixed. If you find any others that for some reason were not covered or not fixed correctly, please let me know. (Also note that the cache will have to pick up all these changes still).

Comment 9

[Dave Garrett]

(In reply to comment #8)
> If you find any others that for some reason were not
> covered or not fixed correctly, please let me know.

(In reply to comment #7)
> (In reply to comment #4)
> > None of the examples in bug 470203 are in that list.
> 
> None of them is in the new list either -- but I take it they've been fixed
> before?

I know I still have 28 versions that need fixing. (5791; Flagfox: all versions except for the oldest 2 were public) Versions uploaded on Dec 22 and Jan 3 are public, but Dec 4 and back are all sandboxed. r20493 says Dec 5, so I'm not sure how it's getting missed here.

Version pages for all those mentioned in bug 470203:
https://addons.mozilla.org/en-US/firefox/addons/versions/4925
https://addons.mozilla.org/en-US/firefox/addons/versions/8045
https://addons.mozilla.org/en-US/firefox/addons/versions/5447
https://addons.mozilla.org/en-US/firefox/addons/versions/5791

AutoPager has some public ones mixed in there, so I don't know what's up with that one.

If we're missing these few then I'm worried we might be missing some others too. Maybe just search for all add-ons with a file posted between Dec 5 or 4 (r20493; bug created) and Dec 26 or 27 (bug 471200; bug fixed).

Comment 10

[Fred Wenzel [:wenzel]]

Flagfox: fixed.
AutoPager: fixed.

I'll also go ahead and search for files created in the time you mention, minus the ones already in the list. Let's see what this turns up.

Comment 11

[Dave Garrett]

Thanks. Must be quite annoying work to fix this all manually.

On the bright side, from comment 8 it looks like that search turned up a whole bunch of zombie add-ons. Good to get them cleaned up, I guess.

Comment 12

[Fred Wenzel [:wenzel]]

Sigh, this search (all public add-ons that uploaded a file in this period of time, and have any sandboxed version prior to this bug being fixed, and were not in the already fixed list) turned up another 133 possible candidates. Thinking about how to maybe narrow it down more.

Comment 13

[Dave Garrett]

Bug 470203 was active for up to 3 weeks. Those could mostly be valid matches.

r20493 probably wasn't pushed right away. If you can find out when the production server got that pushed to it you can search starting from that date instead. Bug 470203 wasn't filed until the 18th so it could've been any time before that.

Comment 14

[Fred Wenzel [:wenzel]]

Good call. I found out a "lower boundary" of the push from bug 469210 comment 7. If I use that instead, the list is reduced to 88 add-ons (in addition to the ones I already fixed).

Will have to go with these. Here's the new list.

220; FlashGot
612; NestedQuote Remover
614; Save Image in Folder
636; PDF Download
1117; FoxClocks
1379; Hebrew Calendar
1493; Littlebird for TB2.0 and 3.0
1494; Nautipolis for TB2.0 and 3.0
1495; Walnut for TB2.0 and 3.0
1657; MicroThunderbird for TB2.0 and 3.0
1730; ScribeFire Blog Editor
2085; Email Notification Randomizer
2278; Ghostfox
2444; FoxLingo
2474; Thunderbird Message Filter Import/Export
2792; Diigo: Web Highlighter and Sticky Notes
2878; draugiem.lv ext
3155; Corrector para Portugues Europeu
3176; Favicon Picker 2
3492; Show InOut
3844; GamesForum Menu
3911; Public Fox
3945; Fotofox
4026; Full Map
4125; It's All Text!
4441; Firefox Companion for Kodak EasyShare Gallery
4550; Compact Menu 2
4617; Online Music Player
4645; FireGPG
4721; .vcs Support
4808; Google Reader Watcher
4862; Webly
4877; BorderColors
4878; Smart Digg Button
4903; Suricate
4925; AutoPager
5043; NHL's Washington Capitals Official Hockey Toolbar and Theme
5054; Search Everywhere
5066; Custom Buttons²
5081; TwitterFox
5579; Cooliris
5657; Bulk Image Downloader
5740; LDS Toolbar Extension
5761; Textarea Cache
5791; Flagfox
5808; Lookpick
5846; Yet Another Smooth Scrolling
5867; Tumblr Post
5881; Glubble for Families
6235; LDS Mingle Toolbar
6336; PMOG
6349; BugMeNot
6424; Better GReader
6462; Dcurrency
6510; FoxReplace
6521; Status-bar Scientific Calculator
6881; Gnome Classic
6882; Nautical Classic
6973; IDM CC
7056; NoUn Buttons
7290; Kongregate Sidebar
7420; Qırımtatarca Til Paketi [Crimean Tatar Language Pack]
7844; Clean Subject
7873; What's the Tide?
7996; ColorResults
8034; Socialbrowse
8045; VertTabbar
8049; GoogleTube
8223; Florida State University
8225; Sugarland Official Toolbar and Theme
8282; Shelve
8497; Smart Find
8758; UrlbarExt
8839; Arctic Glow
8889; glowyblue
8890; glowygold
8891; glowygreen
8892; glowywine
9174; Celebrity pictures, models and more - DJMICK Toolbar and Theme
9223; Bottom Error Console
9300; RulerDark
9517; Toggle Private Browsing
9545; NHL's Calgary Flames Official Hockey Toolbar and Theme
9597; NHL's Montreal Canadiens Official Hockey Toolbar and Theme
9641; Inline Code Finder for Firebug
9689; KidZui
9690; Winter Holiday Christmas Toolbar and Theme
9954; XUL Profiler (by yoono)

Comment 15

[Fred Wenzel [:wenzel]]

All right, here we go again:

220; No change necessary.
612; No change necessary.
614; No change necessary.
636; all versions made public.
1117; No change necessary.
1379; No change necessary.
1493; all versions made public.
1494; all versions made public.
1495; all versions made public.
1657; all versions made public.
1730; all versions made public.
2085; No change necessary.
2278; No change necessary.
2444; No change necessary.
2474; No change necessary.
2792; No change necessary.
2878; No change necessary.
3155; No change necessary.
3176; No change necessary.
3492; No change necessary.
3844; No change necessary.
3911; No change necessary.
3945; all versions made public.
4026; No change necessary.
4125; No change necessary.
4441; all versions made public.
4550; No change necessary.
4617; all versions made public.
4645; all versions made public.
4721; all versions made public (except pending review).
4808; No change necessary.
4862; No change necessary.
4877; No change necessary.
4878; No change necessary.
4903; No change necessary.
4925; No change necessary.
5043; all versions made public.
5054; No change necessary.
5066; No change necessary.
5081; No change necessary.
5579; all versions made public.
5657; No change necessary.
5740; No change necessary.
5761; No change necessary.
5791; No change necessary (fixed before).
5808; No change necessary.
5846; No change necessary.
5867; all versions made public (except pending review).
5881; No change necessary.
6235; No change necessary.
6336; No change necessary.
6349; No change necessary.
6424; No change necessary.
6462; No change necessary.
6510; No change necessary.
6521; No change necessary.
6881; all versions made public.
6882; all versions made public.
6973; No change necessary.
7056; No change necessary.
7290; No change necessary.
7420; No change necessary.
7844; No change necessary.
7873; No change necessary.
7996; all versions made public (except pending review).
8034; No change necessary.
8045; all versions made public (except pending review).
8049; No change necessary.
8223; No change necessary.
8225; all versions made public.
8282; all versions made public (except pending review).
8497; No change necessary.
8758; all versions made public (except pending review).
8839; all versions made public.
8889; all versions made public.
8890; all versions made public.
8891; all versions made public.
8892; all versions made public.
9174; all versions made public.
9223; No change necessary.
9300; all versions made public (except pending review).
9517; all versions made public.
9545; all versions made public.
9597; all versions made public.
9641; No change necessary.
9689; all versions made public.
9690; all versions made public.
9954; all versions made public.

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on production.