471207 - multiline imput field no way back

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[tonda kavalec]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20081226 SeaMonkey/2.0a3pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20081226 SeaMonkey/2.0a3pre

changing single input field in chatzilla to multi-line-field, it is not possible to switch back

Reproducible: Always

Steps to Reproduce:
1. switch to multi-line-input-fiel in chatzilla (mouse / keyboard)
2. try to switch back (mouse / keyboard)
3.
Actual Results:  
switching back to single-input-field is not possible

Expected Results:  
it is always possible to switch back to single-input-field

Comment 1

[therube]

Looks to be broken in Windows too.

ChatZilla 0.9.84 [SeaMonkey 2.0a3pre/20081229001333]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081229 SeaMonkey/2.0a3pre

Comment 2

[therube]

Regression range:

ChatZilla 0.9.84 [SeaMonkey 2.0a3pre/20081221001336] - works

ChatZilla 0.9.84 [SeaMonkey 2.0a3pre/20081222001336] - broken

Comment 3

[therube]

I have no clue if this is meaningful?

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-12-21&maxdate=2008-12-23&cvsroot=%2Fcvsroot

Comment 4

[James Ross]

I'm pretty sure this is a regression from bug 436759.

Comment 5

[James Ross]

To be clear, the problem here is that the PrefManager is calling onPrefChanged in prefs.js for the "multiline" pref with the old value as "false" even when it should be "true". The code thus wont switch to single-line as it sees false -> false and aborts.

Comment 6

[James Ross]

OK, what I think is happening is that the PrefManager is removing the old value in clearPref BEFORE we actually remove the preference. For the normal setPref code-path, the internal value is only updated after setting the pref.

I should be able to patch this...

Comment 7

[James Ross]

Attachment: Always update the realValue after changing the preference

This fixes the problem with the multiline input box; I commented on both places so nobody regresses this in the future.

Comment 8

[:Gijs (he/him)]

Comment on attachment 354784 [details] [diff] [review]
Always update the realValue after changing the preference

Nice one!
r=me

Comment 10

[Tony Mechelynck [:tonymec]]

- Workaround: The multiline input box can be resized, even to single line, by dragging its top side.
- Problem with this workaround: Ctrl+Up still isn't active, until you /quit then reopen ChatZilla.

This is probably a bit late for a workaround, since it looks like this bug will soon be FIXED.

Comment 11

[:Gijs (he/him)]

(In reply to comment #10)
> - Workaround: The multiline input box can be resized, even to single line, by
> dragging its top side.
> - Problem with this workaround: Ctrl+Up still isn't active, until you /quit
> then reopen ChatZilla.

And enter doesn't send messages, tab doesn't autocomplete, and there is no history. So it's a really lousy workaround... this just needs to get checked in, and it will...

> 
> This is probably a bit late for a workaround, since it looks like this bug will
> soon be FIXED.

Comment 12

[tonda kavalec]

for me Enter sends messages
tab does autocomplete
ctrl + up works as well

Comment 13

[James Ross]

Checked in --> FIXED.