Closed Bug 471213 Opened 16 years ago Closed 15 years ago

[10.4] Background tabs draw incorrectly when dragging

Categories

(Camino Graveyard :: Tabbed Browsing, defect)

Product:
Camino Graveyard
Component:
Tabbed Browsing
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Camino2.0

People

(Reporter: chris, Assigned: murph)

References

Details

Attachments

(2 files)

Tab drawing issues on Tiger
200.56 KB, image/png
Details
Fix
1.64 KB, patch
stuart.morgan+bugzilla
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
Camino 2.0b1 on 10.4.11 (Intel iMac).

I'm seeing 'ghosts' of background tabs when dragging with 2.0b1 on 10.4.11
(Intel iMac). The background tabs don't slide either; they just snap into their
new positions and leave behind remnants. The current tab slides smoothly,
however.

It may be related to what Bug 160720 Comment 70 describes.
Summary: Background tabs draw incorrectly when dragging in Tiger → [10.4] Background tabs draw incorrectly when dragging
Taking a look at this.
Assignee: nobody → murph
Attached patch Fix — — Splinter Review 
When my CHSlidingViewAnimation alters the animating view's frame rectangle, I mistakingly forgot to mark the appropriate views as needing display.  When using the setFrame... methods this does not happen automatically; we must mark both the view being repositioned and its superview as needing display.

Since the code did work on Leopard without controlling display, I can't help but wonder if some code was introduced to automatically cause the moving view and its superview to redisplay when changing frames :-/.
Attachment #359295 - Flags: review?(stuart.morgan+bugzilla)
Attachment #359295 - Flags: superreview?(mikepinkerton)
Attachment #359295 - Flags: review?(stuart.morgan+bugzilla)
Attachment #359295 - Flags: review+
Comment on attachment 359295 [details] [diff] [review]
Fix

r=me
Comment on attachment 359295 [details] [diff] [review]
Fix

sr=pink
Attachment #359295 - Flags: superreview?(mikepinkerton) → superreview+
Landed on cvs trunk.
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: camino2.0? → camino2.0+
Resolution: --- → FIXED
Target Milestone: --- → Camino2.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: