Closed
Bug 471229
Opened 16 years ago
Closed 15 years ago
can't type an apostrophe or parenthesis in text fields
Categories
(Toolkit Graveyard :: Spatial Navigation, defect)
Toolkit Graveyard
Spatial Navigation
Tracking
(fennec1.0b3+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fennec | 1.0b3+ | --- |
People
(Reporter: db48x, Assigned: tonikitoo)
References
Details
(Keywords: mobile)
Attachments
(1 file, 2 obsolete files)
1.80 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
instesd it selects the previous field, which is rather unexpected and dangerous; try it in a bug description. perhaps it activates snav?
Assignee | ||
Comment 1•16 years ago
|
||
reproducible. taking
Assignee: nobody → tonikitoo
Status: NEW → ASSIGNED
Updated•15 years ago
|
tracking-fennec: --- → ?
Updated•15 years ago
|
tracking-fennec: ? → 1.0b3+
Assignee | ||
Comment 2•15 years ago
|
||
err , i was the root of the problem. that is where we are breaking: http://mxr.mozilla.org/mozilla-central/source/toolkit/spatial-navigation/SpatialNavigation.js#92
Assignee | ||
Comment 4•15 years ago
|
||
dougt, I actually changed my mind from bug 463139, where I accidentally broken this. I explain: we have different keys that share the same |event.which| and |event.keyCode| codes. e.g. keyCode for ARROW_RIGHT -> 39 charCode for APOSTOPHE -> 39 when user types the character ' then snav assumes it is an arrow press, once we are using event.which. that is bad...
Attachment #380995 -
Flags: review?(doug.turner)
Assignee | ||
Updated•15 years ago
|
Component: General → Spatial Navigation
Keywords: mobile
Product: Fennec → Toolkit
QA Contact: general → spatial.navigation
Comment 5•15 years ago
|
||
antonio, would it be better to check to see if keyCode == charCode, then use event.keyCode. Otherwise use (event.which || event.keyCode).
Comment 6•15 years ago
|
||
(In reply to comment #5) > antonio, > would it be better to check to see if keyCode == charCode, then use > event.keyCode. Otherwise use (event.which || event.keyCode). This fails. Antonio's fix works.
this also affects non mobile.
Severity: normal → major
OS: Linux → All
Hardware: Other → All
Summary: cant type an apostrophe in text fields → can't type an apostrophe or parenthesis in text fields
Assignee | ||
Comment 8•15 years ago
|
||
Alternative solution for the problem. 1) It basically adds a special handling for when event.charCode is equal the one of the arrow keys keyCode. it fixes apostrophe and parenthesis cases, and similar ones ...
Attachment #380995 -
Attachment is obsolete: true
Attachment #385933 -
Flags: review?(doug.turner)
Attachment #380995 -
Flags: review?(doug.turner)
Comment 9•15 years ago
|
||
Comment on attachment 385933 [details] [diff] [review] patch 0.2 - simple fix for the problem lets not use comparison operators, but use explicit checks against the values in nsIDOMKeyEvent.*. I do not think they will change, but I am not sure that there is a guarantee.
Attachment #385933 -
Flags: review?(doug.turner) → review-
Assignee | ||
Comment 10•15 years ago
|
||
(In reply to comment #9) > (From update of attachment 385933 [details] [diff] [review]) > lets not use comparison operators, but use explicit checks against the values > in nsIDOMKeyEvent.*. I do not think they will change, but I am not sure that > there is a guarantee.
Attachment #385933 -
Attachment is obsolete: true
Attachment #386078 -
Flags: review?(doug.turner)
Assignee | ||
Comment 11•15 years ago
|
||
(In reply to comment #9) > (From update of attachment 385933 [details] [diff] [review]) > lets not use comparison operators, but use explicit checks against the values > in nsIDOMKeyEvent.*. I do not think they will change, but I am not sure that > there is a guarantee. suggestion addressed. patch also changes the order of the snav.enabled pref status check to be the first thing to be checked before going on...
Updated•15 years ago
|
Attachment #386078 -
Flags: review?(doug.turner) → review+
Comment 12•15 years ago
|
||
Antonio - fix the spacing on the "||" please? + key == Ci.nsIDOMKeyEvent.DOM_VK_RIGHT|| key == Ci.nsIDOMKeyEvent.DOM_VK_UP))
Assignee | ||
Comment 13•15 years ago
|
||
fixed. changeset: 29918:ebbcf6317c98 tag: tip user: Antonio Gomes (tonikitoo) <tonikitoo@gmail.com> date: Tue Jun 30 16:35:53 2009 -0400 summary: Bug 471229 - can't type an apostrophe or parenthesis in text fields. r=dougt (In reply to comment #12) > Antonio - fix the spacing on the "||" please? > > + key == Ci.nsIDOMKeyEvent.DOM_VK_RIGHT|| key == > Ci.nsIDOMKeyEvent.DOM_VK_UP)) done daniel, timeless: please verify
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Blocks: 1243213
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•