471284 - [he] Change the useragent locale string from 'he-IL' to 'he'

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Tomer Cohen :tomer]

Currently Firefox useragent contain the string 'he-IL' for the Hebrew locale (on he/toolkit/chrome/global/intl.properties). As far as I understand, this is wrong and we should change it to 'he' only. 

After investigating the situation with other locales[1], it looks quite common to use two letters locale string in the useragent such as 'fr' and not 'fr-FR'. But changing this might make an impact on systems that relay on that string.

What do you advise? Should I change it to 'he' or keep it as 'he-IL'? Please remember that we use 'he' in other places. 


[1] Query of all locales - http://mxr.mozilla.org/l10n/search?string=general.useragent.locale&find=intl.properties&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n

Comment 1

[Axel Hecht [:Pike]]

If you have he-IL in your user agent string, you're doing so from a very old profile and a user-set pref.

intl.properties isn't used, at least that's what my tests with changing general.useragent.locale in about:config shows.

Comment 2

[Tomer Cohen :tomer]

(In reply to comment #1)
> intl.properties isn't used, at least that's what my tests with changing
> general.useragent.locale in about:config shows.

Checking from a live profile, I can confirm your check (mine is Mozilla/5.0 (X11; U; Linux i686 (x86_64); he; rv:1.9.1b2pre) Gecko/20081124 Minefield/3.1b2pre). So we may having a obsolete string. 

Do we have a test to check if that string is actually used anywhere on our codebase?

Comment 3

[Axel Hecht [:Pike]]

There are some heuristics, but nothing definite, in particular for .properties files, as the keys can be (and sometimes are) programmatically created.

As for this string, I'm not sure if SeaMonkey uses this string.