Closed Bug 471285 Opened 13 years ago Closed 13 years ago

Workers: Spec for runtime error behavior has changed

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

(Keywords: addon-compat, fixed1.9.1)

Attachments

(1 file)

Attached patch Patch,v1Splinter Review
Small changes to runtime errors have been introduced into the spec, see http://www.whatwg.org/specs/web-workers/current-work/#runtime

Patch attached.
Flags: blocking1.9.1?
Attachment #354571 - Flags: superreview?(jonas)
Attachment #354571 - Flags: review?(jonas)
Flags: blocking1.9.1? → blocking1.9.1+
Attachment #354571 - Flags: superreview?(jst)
Attachment #354571 - Flags: superreview?(jonas)
Attachment #354571 - Flags: review?(jst)
Attachment #354571 - Flags: review?(jonas)
Comment on attachment 354571 [details] [diff] [review]
Patch,v1

Add the missing newline at the end of nsDOMWorkerEvents.cpp.

r+sr=jst
Attachment #354571 - Flags: superreview?(jst)
Attachment #354571 - Flags: superreview+
Attachment #354571 - Flags: review?(jst)
Attachment #354571 - Flags: review+
Pushed changeset 1c68eb288c85 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: late-compat
Resolution: --- → FIXED
Had to back this out for a mochitest that was timing out (test_scopeOnerror.html).

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1230676718.1230679237.7642.gz&fulltext=1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Fixed again, changeset 068d562872dc on mozilla-central. Needed to tweak the tests to prevent timeouts on linux, see changeset 25ba82075a6d.

Also found bug 471920.
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
Pushed changeset d27cd2907bea to mozilla-1.9.1.
Keywords: fixed1.9.1
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.