Closed Bug 471299 Opened 11 years ago Closed 11 years ago
retry code and comments in ns
Url Classifier Store::Write Entry are wrong
http://hg.mozilla.org/mozilla-central/annotate/2bbf690dac7e/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp#l1943 The code and comment imply that mInsertStatement uses a random insertion point, but as far as I can tell it just does an "INSERT OR REPLACE INTO". Bart points out that this code might have been there to deal with a previous patch that did do random insertions. We should fix the comment and remove the unnecessary retrying code.
Related bug is bug 419117.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #354613 - Flags: review?(dcamp)
Comment on attachment 354613 [details] [diff] [review] patch Yeah, that snuck in during the first rev of 419117, oops.
Attachment #354613 - Flags: review?(dcamp) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
You need to log in before you can comment on or make changes to this bug.