Closed
Bug 471299
Opened 16 years ago
Closed 16 years ago
retry code and comments in nsUrlClassifierStore::WriteEntry are wrong
Categories
(Toolkit :: Safe Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3.6a1
People
(Reporter: Gavin, Assigned: Gavin)
Details
Attachments
(1 file)
|
1.90 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/annotate/2bbf690dac7e/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp#l1943 The code and comment imply that mInsertStatement uses a random insertion point, but as far as I can tell it just does an "INSERT OR REPLACE INTO". Bart points out that this code might have been there to deal with a previous patch that did do random insertions. We should fix the comment and remove the unnecessary retrying code.
|
||
Comment 1•16 years ago
|
||
Related bug is bug 419117.
|
Assignee | |
Comment 2•16 years ago
|
||
|
||
Comment 3•16 years ago
|
||
Comment on attachment 354613 [details] [diff] [review] patch Yeah, that snuck in during the first rev of 419117, oops.
Attachment #354613 -
Flags: review?(dcamp) → review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•16 years ago
|
Flags: in-testsuite-
|
|
Assignee | |
Comment 4•16 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8686ad847fad
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
|
||
Updated•10 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•