Closed Bug 471321 Opened 15 years ago Closed 9 years ago

Needs for an UI to run changeset queries

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: whimboo, Assigned: sid)

References

()

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1096] )

Attachments

(1 file, 1 obsolete file)

There is currently no ui which simplifies the changesets query. You have to enter the query by hand which makes it harder to use. Even a lot of us will not know that this feature exists.

It would be great if we could have an option (drop down) to select the criteria we want to run a query against hg and simply have to put both changesets into the text boxes.
Assignee: nobody → sid
Status: NEW → ASSIGNED
Implemented a drop down menu allowing the user to choose between entering dates or changesets.

More details: http://blog.sidkalra.com/2009/03/v08-release-implementing-the-changeset-query-ui/
Attachment #369912 - Flags: review?(ted.mielczarek)
Comment on attachment 369912 [details] [diff] [review]
Changeset Query UI for hg_templates

Quick review:
+    fromBox.value="#fromchange|escape#";

I don't think you should set the value when the dropdown changes. This would mean that whatever the user has already entered will be overwritten. That doesn't sound cool. Also, it would be cool if the code could figure out if you had already done a changeset query, and if so, pre-set the dropdown to changeset, and fill the changesets into the boxes.
Attachment #369912 - Flags: review?(ted.mielczarek) → review-
Please see the following link for more details:

http://blog.sidkalra.com/2009/04/v09-release-implementing-changes-to-the-changset-query-ui/
Attachment #369912 - Attachment is obsolete: true
Attachment #372297 - Flags: review?(ted.mielczarek)
Ted, looking at your review queue, these patches go back a while.  Do you have review comments that haven't been addressed in order for you to r+?  If not, are you planning to review?  And, if you don't think we should take these, can you r-?  

If there are comments that have yet to be addressed, does it make sense to clear these requests and ask for another request after the comments have been addressed?
Comment on attachment 372297 [details] [diff] [review]
Changeset Query UI for hg_templates

Clearing old review requests. We can revisit these at a later date.
Attachment #372297 - Flags: review?(ted.mielczarek)
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/103]
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/103] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1087] [kanban:engops:https://kanbanize.com/ctrl_board/6/103]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1087] [kanban:engops:https://kanbanize.com/ctrl_board/6/103] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1095] [kanban:engops:https://kanbanize.com/ctrl_board/6/103]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1095] [kanban:engops:https://kanbanize.com/ctrl_board/6/103] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1096] [kanban:engops:https://kanbanize.com/ctrl_board/6/103]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1096] [kanban:engops:https://kanbanize.com/ctrl_board/6/103] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1096]
This is a great idea. But it should be fixed upstream and make into a core feature of Mercurial's built-in styles.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Note that this is about the *pushlog* changeset query, not Mercurial.
I'm adding revset queries to the new pushlog extension in bug 1116886. Once that is in place, we can use the search box to query based on pushlog data. I believe that will satisfy the spirit of this request (although without the nice web UI).
You need to log in before you can comment on or make changes to this bug.