Closed Bug 471330 Opened 13 years ago Closed 10 years ago

Icon deck of an instant search widget not updated when undoing the last action

Categories

(Toolkit :: XUL Widgets, defect)

1.9.1 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: whimboo, Unassigned)

References

Details

(Whiteboard: [will be fixed by bug 318065])

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20081227 Shiretoko/3.1b3pre ID:20081227020351

When the undo function from the context menu of a search widget, which is doing an instant search, is used the icon deck isn't updated. Means the clear icon is still shown even with an empty value.

STR:
1. Open about:config and enter some text into the search bar
2. Select 'Undo' from its context menu

After step 2 no value is set anymore but the clear icon still persists on the right side. Clicking on it doesn't remove it as what users expect.

We have to listen for value changes and update the icon deck accordingly.
You can also add some more steps:

1. Open about:config and enter some text, e.g. "access" into the search bar
2. Delete the entered text
3. Select 'Undo' from its context menu

With step 3 the search is performed but the icon deck is not updated too. The clear icon isn't visible.

Means that any undo action doesn't update the icon deck.
Graeme, will this be fixed by one of your undo patches? Bug 471319 or bug 471776?
> Graeme, will this be fixed by one of your undo patches?

Yes, but what you need is my other undo patch! Bug 318065 will fix this.
Depends on: 318065
Whiteboard: [will be fixed by bug 318065]
This should be fixed by the landing of bug 318065 on mozilla-central (http://hg.mozilla.org/mozilla-central/rev/170e2522e530)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.