Closed Bug 471363 Opened 15 years ago Closed 15 years ago

localization notes in mime.properties pointing to the wrong entities (Thunderbird part)

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: adriank, Assigned: philor)

References

Details

Attachments

(1 file, 1 obsolete file)

looks like not properly done copy and paste from other localization notes in the same file:

# Partial Message Format2 1
## @name MIME_MSG_PARTIAL_FMT2_1
## @loc
# LOCALIZATION NOTE (1037): In the following line, translate only the words, "Not Downloaded".
1042=<P><CENTER><TABLE BORDER CELLSPACING=5 CELLPADDING=10 WIDTH="80%%"><TR><TD ALIGN=CENTER><FONT SIZE="+1"><B>Not Downloaded</B></FONT><HR>

# Partial Message Format2 2
## @name MIME_MSG_PARTIAL_FMT2_2
## @loc
# LOCALIZATION NOTE (1038): Translate the following two lines as a single sentence. In the middle of the two sections
# there will be a URL. You may translate the text in any order you wish, but the html tags must stay in the same locations.
# In particular, the "<B>" tag must begin the first section, which must end with the "<A HREF=" tag. Do not translate the html tag,"<P>"
1043=<B>Only the headers for this message were downloaded from the mail server.<P>Click <A HREF="

# Partial Message Format2 3
## @name MIME_MSG_PARTIAL_FMT_3
## @loc
# LOCALIZATION NOTE (1039): This section must begin with the ">" sign and end with the tags,"</B></TD></TR></TABLE></CENTER>"
# Do not translate "</A>" tag.
1044=">here</A> to download the rest of the message.</B></TD></TR></TABLE></CENTER>



Note: that probably breaks some L10n-tools, which are looking for the entity specified in the localization note.
Attached patch Fix (obsolete) — Splinter Review
Oh, my. Goodness, gracious. Someone *please* tell me that this horrific .properties file, this astonishingly complete example of how not to localize strings, is at least the very worst one in the tree. I started out looking at just fixing the whole thing (it makes you localize a string that starts with the closing quote of a link's href!), but I realized before long that the odds favored me deciding to self-lobotomize before I got past the first three strings (which I'm pretty sure are never, ever, actually shown, just used as NS_ERROR_FAILURE-equivalents).
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #354655 - Flags: superreview?(bugzilla)
Attachment #354655 - Flags: review?(bugzilla)
Blocks: 471364
Attached patch Fix v.2Splinter Review
Honestly, how can you not hate this stuff with every fiber of your being? The interdiff from the last patch will show that this one corrects the made-up style "@name MIME_MSG_PARTIAL_FMT_3" for "Partial Message Format2 3" to be ""@name MIME_MSG_PARTIAL_FMT2_3". Bleah.
Attachment #354655 - Attachment is obsolete: true
Attachment #354664 - Flags: superreview?(bugzilla)
Attachment #354664 - Flags: review?(bugzilla)
Attachment #354655 - Flags: superreview?(bugzilla)
Attachment #354655 - Flags: review?(bugzilla)
Attachment #354664 - Flags: superreview?(bugzilla)
Attachment #354664 - Flags: superreview+
Attachment #354664 - Flags: review?(bugzilla)
Attachment #354664 - Flags: review+
http://hg.mozilla.org/comm-central/rev/15b1cc3e7b26
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.