Closed Bug 471415 Opened 11 years ago Closed 11 years ago

Opening chrome:// URLs in browser is broken

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: gaubugzilla, Assigned: mfinkle)

References

()

Details

Attachments

(1 file)

When opening a chrome:// URL like chrome://global/content/console.xul in browser I see the following error:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIIOService.newURI]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://browser/content/browser-ui.js :: anonymous :: line 126"  data: no]

That refers to this line in BrowserUI._setIcon:

var faviconURI = ios.newURI(aURI, null, null);

Loading indicator never stops and there is some more oddness to this tab (it is never drawn in the list of tabs and once you switch to some other tab switching back is quite difficult).
Attached patch patchSplinter Review
The URI we try to use as the favicon URI is not a valid chrome URI. chrome://global/content/console.xul yields a chrome://global/favicon.ico URI.

This patch adds a try/catch around the .newURI call and adds another fallback to the default favicon.
Assignee: nobody → mark.finkle
Attachment #354736 - Flags: review?(gavin.sharp)
Attachment #354736 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mobile-browser/rev/98aa87d2efc2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/200910002
Fennec/1.0b4
Status: RESOLVED → VERIFIED
We need a general testcase about opening xul documents in the browser as a test in our BFTs.
Flags: in-litmus?
You need to log in before you can comment on or make changes to this bug.