471438 - WHATWG Drag and drop, dropping to an element with ondrop defined navigates to location of the dropped object

Status: RESOLVED FIXED

(Core :: DOM: Drag & Drop, defect, P1)

Description

[Honza Bambas (:mayhemer)]

STR:
1. load the URL at this bug
2. drag one of the images at the bottom to one of the boxes
3. the image is dropped to the box 

The bug: the tab navigates to the image location

Expected:
the window/tab is not navigated to the image

The WHATWG example from the URI works in IE7 and Safari 3.2.1 as expected but not in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b3pre) Gecko/20081229 Shiretoko/3.1b3pre ID:20081229020258

I didn't test with Shiretoko on windows or linux. I did try to remove the preventDefault call from the drop handler, behavior is unchanged in Safari (still correct) nor in Firefox (still buggy).

Comment 1

[Neil Deakin]

Attachment: don't drop links if already handled

The Firefox frontend has its own code for handling dropped links for some reason, so make sure to check if the event has been cancelled.

Comment 2

[Honza Bambas (:mayhemer)]

Confirming this patch works as I would expect.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 354721 [details] [diff] [review]
don't drop links if already handled

r=me

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Any reason why this hasn't landed on 191?

Comment 6

[Damon Sicore (:damons)]

Echo:  Any reason why this hasn't landed on 1.9.1?

If it's because Neil is away until the 8th, can someone else land?

Comment 7

[Honza Bambas (:mayhemer)]

I can do that.

Comment 8

[Honza Bambas (:mayhemer)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/398de0eecb2d