Closed Bug 471501 Opened 15 years ago Closed 15 years ago

Remove unused mime.properties strings

Categories

(MailNews Core :: MIME, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch Remove 'emSplinter Review
Unlike some bits of libmime's strings (bug 471445 and bug 471487 in particular), these are pretty straightforward: you can get at a MIME_FOO_ string by either knowing the macro name for the id and passing that to MimeGetStringByID (straight or via MimeGetNamedString), or by passing the header name through MapHeaderNameToID to get a MIME_MHTML_ id macro to pass to MimeGetStringByID. Either way has to leave mxr-tracks, and so

http://mxr.mozilla.org/comm-central/search?string=MIME_MHTML_NAME
http://mxr.mozilla.org/comm-central/search?string=MIME_MHTML_TYPE
http://mxr.mozilla.org/comm-central/search?string=MIME_MHTML_ENCODING
http://mxr.mozilla.org/comm-central/search?string=MIME_MHTML_DESCRIPTION
http://mxr.mozilla.org/comm-central/search?string=MIME_MHTML_RESENT_MESSAGE_ID
http://mxr.mozilla.org/comm-central/search?string=MIME_MHTML_DOWNLOAD_STATUS_HE
http://mxr.mozilla.org/comm-central/search?string=MIME_MHTML_DOWNLOAD_STATUS_NO
http://mxr.mozilla.org/comm-central/search?string=MIME_FORWARDED_MESSAGE_ATTACH
http://mxr.mozilla.org/comm-central/search?string=MIME_MSG_ADDBOOK_MOUSEOVER_TE
http://mxr.mozilla.org/comm-central/search?string=MIME_MSG_XSENDER_INTERNAL
http://mxr.mozilla.org/comm-central/search?string=MIME_MSG_X_USER_WROTE
http://mxr.mozilla.org/comm-central/search?string=MIME_MSG_USER_WROTE
http://mxr.mozilla.org/comm-central/search?string=MIME_MSG_NO_HEADERS
http://mxr.mozilla.org/comm-central/search?string=MIME_MSG_SHOW_ATTACHMENT_PANE
http://mxr.mozilla.org/comm-central/search?string=MIME_MSG_NOT_DOWNLOADED

all showing just the two .properties files and the one #define say that those are all unused.
Attachment #354785 - Flags: superreview?(bienvenu)
Attachment #354785 - Flags: review?(bienvenu)
Attachment #354785 - Flags: superreview?(bienvenu)
Attachment #354785 - Flags: superreview+
Attachment #354785 - Flags: review?(bienvenu)
Attachment #354785 - Flags: review+
Comment on attachment 354785 [details] [diff] [review]
Remove 'em

thx, Phil.
http://hg.mozilla.org/comm-central/rev/781f6cdc8486
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.