471613 - Replace Bugzilla::Util::is_tainted() by Scalar::Util::tainted()

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

Scalar::Util is in Perl by default now, so we can use its tainted() subroutine instead of our own is_tainted() one.

Comment 1

[Nitish Bezzala]

Attachment: Removed is_tainted(), and replaced with tainted()

Please let me know how to test this.

Comment 2

[Frédéric Buclin]

Comment on attachment 358569 [details] [diff] [review]
Removed is_tainted(), and replaced with tainted()

>Index: Install/Util.pm

>+use Scalar::Util qw(tainted);

Nit: move this line lower in the code, together with other "use" calls. I will fix that on checkin. r=LpSolit


Next time, please create your diff from the bugzilla/ root directory, even if all files you modified are in a specific directory. It's a pain to guess in which directory you were when you created your patch.

Comment 3

[Frédéric Buclin]

Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.81; previous revision: 1.80
done

Comment 4

[Frédéric Buclin]

Hehe, I didn't copy the whole CVS output message...

Checking in Bugzilla/Install/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Util.pm,v  <--  Util.pm
new revision: 1.17; previous revision: 1.16
done