471691 - Favicons override bookmark changed/updated icons

Status: NEW

(SeaMonkey :: Themes, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

[Note that this might not be the correct component as far as a possible fix is concerned but part of this is theme-specific.]

Found while trying to reproduce Bug 244647 (which I'm going to close as WFM):

When a bookmark is set to be checked for updates regularly (see test case below) and the bookmark's icon to be changed as a notification the icon is not changed if a website icon (favicon) for that site is displayed instead of the normal bookmark icon.

Steps to Reproduce:
1. create a bookmark for a site that has a favicon and changes often, e.g. Google News <http://news.google.de/news?ned=tde&rec=0>
2. enter the bookmark's properties and set it to always check (Every Day, Midnight to Midnight, every 1 minutes), "Change the bookmark's icon" and "Display an alert" (for verification)
3. leave dialog with OK
4. check "Edit > Preferences > Appearance > Content > Show website icons" is active
5. visit the site
6. restart the application and verify that the bookmark's icon is the website's icon
7. wait for the site update check to kick in (a dialog will be displayed)

Actual Results:
The bookmark icon doesn't change.

Expected Results:
The bookmark icon should have changed to the one defined for updated bookmarks, just like when bookmarks show no website icons.

Background Info:
- the icon for updated bookmarks is defined in the themes' bookmarks.css, [status="new"] case. Adding !important doesn't help to fix this bug (at least it's not enough by itself)
- the status property is set to "new" in nsBookmarksService::OnStopRequest().

ToDo:
The themes' bookmarks.css files define chrome://global/skin/loading.gif for use in the [container="true"][open="true"][loading="true"] case. That file doesn't exist (anymore?) in either theme. :-(