Editor Tools: add 'prev' and 'next buttons to review pages

VERIFIED FIXED in 5.0.1

Status

--
enhancement
VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: osunick, Assigned: wenzel)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
When reviewing pending and nomination queues, it requires a lot of clicks to page through the add-ons for quick review.  Can we throw in some navigation into those pages?

It'd be great if we could get this done quickly as we start to bring on more heads on the editor team.  Thanks!
Assignee: nobody → fwenzel
Target Milestone: --- → 5.0.1
(Assignee)

Comment 1

10 years ago
Clarification: After reading discussions on amo-editors, I realized these navigation links are supposed to be on the individual addons' editor review pages, much link in bugzilla for individual bugs from a bug list.
Hardware: x86 → All
(Reporter)

Comment 2

10 years ago
Exactly.  Sorry if that wasn't clear earlier!
(Assignee)

Comment 3

10 years ago
Created attachment 357680 [details] [diff] [review]
add prev/next buttons to review pages, rev 1

This patch adds a prev/next button to the review page. I am using the current queue position as a GET parameter, so I don't have to pass too much information around. Les, do you mind taking a look at this? Should be quite straightforward.

Or, if you want to review it yourself, Nick, go ahead :)
Attachment #357680 - Flags: review?(lorchard)
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
Attachment #357680 - Flags: review?(lorchard) → review+
Comment on attachment 357680 [details] [diff] [review]
add prev/next buttons to review pages, rev 1

Might want to try getting the patch applied on khan to let Nick look at it, but works for me!
(Reporter)

Comment 6

10 years ago
Perfect!
(Assignee)

Comment 7

10 years ago
I replaced the strings with l10n tags and committed it to r21653. I am going to notify the localizers shortly.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
Verified FIXED for en-US on https://preview.addons.mozilla.org/en-US/firefox/editors/review/57172?num=522; I checked both bounds and JavaScript-disabled views, additionally.
Status: RESOLVED → VERIFIED
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.