471706 - Editor Tools: add 'prev' and 'next buttons to review pages

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, enhancement)

Description

[Nick Nguyen [:osunick]]

When reviewing pending and nomination queues, it requires a lot of clicks to page through the add-ons for quick review.  Can we throw in some navigation into those pages?

It'd be great if we could get this done quickly as we start to bring on more heads on the editor team.  Thanks!

Comment 1

[Fred Wenzel [:wenzel]]

Clarification: After reading discussions on amo-editors, I realized these navigation links are supposed to be on the individual addons' editor review pages, much link in bugzilla for individual bugs from a bug list.

Comment 2

[Nick Nguyen [:osunick]]

Exactly.  Sorry if that wasn't clear earlier!

Comment 3

[Fred Wenzel [:wenzel]]

Attachment: add prev/next buttons to review pages, rev 1

This patch adds a prev/next button to the review page. I am using the current queue position as a GET parameter, so I don't have to pass too much information around. Les, do you mind taking a look at this? Should be quite straightforward.

Or, if you want to review it yourself, Nick, go ahead :)

Comment 4

[Les Orchard [:lorchard]]

Comment on attachment 357680 [details] [diff] [review]
add prev/next buttons to review pages, rev 1

Might want to try getting the patch applied on khan to let Nick look at it, but works for me!

Comment 5

[Fred Wenzel [:wenzel]]

Nick: http://skitch.com/fredw/bb4b2/review-queue-nav-buttons

Comment 6

[Nick Nguyen [:osunick]]

Perfect!

Comment 7

[Fred Wenzel [:wenzel]]

I replaced the strings with l10n tags and committed it to r21653. I am going to notify the localizers shortly.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED for en-US on https://preview.addons.mozilla.org/en-US/firefox/editors/review/57172?num=522; I checked both bounds and JavaScript-disabled views, additionally.