471778 - Drop support for type="timed" for textboxes, in ChatZilla ( affects the search in Join channel )

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Comment 1

[James Ross]

Attachment: [checked in] Use "search" binding when available

This makes the filter box type=search, and falls back to type=timed if the binding isn't there (if there's a better way to check the binding has applied, suggest it). It works on Firefox 3.0.whateveritistoday and Firefox 3.1 Beta 2 (obviously only the later getting the search icon).

I don't know what we'll do with the two other filters on the side, they have no need, nor room, for the type=search periphery, and yet type=timed is being deprecated.

Comment 2

[:Gijs (he/him)]

I'm confused. If the timeout is not there, isn't this going to start filtering the list immediately, which is not so nice? Or does it require hitting return, which is also not nice because we use it to actually join the selected/typed channel?

Perhaps adding our own timeout textbox as suggested in bug 449045 is the best solution here (though the most annoying and stupid to implement).

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #2)
> I'm confused. If the timeout is not there, isn't this going to start filtering
> the list immediately, which is not so nice?

type="search" implies a timeout, which defaults to 500 ms.

Comment 4

[:Gijs (he/him)]

(In reply to comment #3)
> (In reply to comment #2)
> > I'm confused. If the timeout is not there, isn't this going to start filtering
> > the list immediately, which is not so nice?
> 
> type="search" implies a timeout, which defaults to 500 ms.

I see.

In this case, I guess we can also use the search type for the other two textboxes, and add some CSS with some sprinkling of !important to nuke the peripherial magnifying glass and so on?

Comment 5

[Dão Gottwald [:dao]]

That's an option, yes.

Comment 6

[:Gijs (he/him)]

Comment on attachment 355034 [details] [diff] [review]
[checked in] Use "search" binding when available

r=me, and I would take a patch for the other boxes to have this done as well, with additional CSS so they don't end up looking hideous. :-)

Comment 7

[James Ross]

Attachment: Join Channel dialog with 3 search boxes

It doesn't look that bad with the search image (I'd forgotten how wide the boxes were) and it gives a clickable "clear" function. I'm happy to do it without the CSS.

Comment 8

[James Ross]

Attachment: [checked in] Convert min/max user filters to type="search"

Comment 9

[:Gijs (he/him)]

Hrm. Do we know what it looks like on other OSes? I would check Mac myself later tonight, but if someone can get a Gnome screenie that'd be good.

Comment 10

[:Gijs (he/him)]

Attachment: Looks on Mac OS X :-(

So, I don't think we should do without the CSS. This is what things look like on Mac, when you start typing. You can fit 1 number between the spyglass and the X. :-(

Comment 11

[Dão Gottwald [:dao]]

(In reply to comment #10)
> Created an attachment (id=357649) [details]
> Looks on Mac OS X :-(

Doesn't look like your build contains the fix for bug 450800.

Comment 12

[:Gijs (he/him)]

Attachment: Trunk screenie

(In reply to comment #11)
> (In reply to comment #10)
> > Created an attachment (id=357649) [details] [details]
> > Looks on Mac OS X :-(
> 
> Doesn't look like your build contains the fix for bug 450800.

Uh, ok. So, I got trunk, and it can now fit 2 digits before filling the box. I'm still not happy with it. Also, I don't see a particularly big difference with the previous screenie, but I suppose that's just me.

Comment 13

[James Ross]

Typical Mac, two icons and wasting space with excessively rounded corners.

Comment 14

[Dão Gottwald [:dao]]

Does adding cocoa-size="small" help?

Comment 15

[:Gijs (he/him)]

(In reply to comment #14)
> Does adding cocoa-size="small" help?

That allows three digits, and though it does make it a scrolling textbox at that point, they are all visible. It looks cramped though... I'd be happier if we could just remove at least the search icon. I don't see why it's necessary, the label is clear enough and in fact minima/maxima have nothing to do with a spyglass, the metaphor is completely lost whatever the case.

Comment 16

[:Gijs (he/him)]

I should note, the crampedness is increased specifically by using cocoa-small because it also adjusts the vertical size of the box.

Comment 17

[Dão Gottwald [:dao]]

You can remove the clear icon using #minUsers .textbox-search-clear { list-style-image: none; }. You can remove the rounded corners and the search glass using #minUsers { -moz-appearance: textfield; padding: 0; }.

Comment 18

[:Gijs (he/him)]

Comment on attachment 357578 [details] [diff] [review]
[checked in] Convert min/max user filters to type="search"

OK, so, r+ for these bits, but can you do a followup patch to nuke the silly images using the CSS Dao mentioned? Thanks!

Comment 19

[James Ross]

So, the padding: 0; trashes the textbox's appearance on Windows. Any better ideas?

Comment 20

[James Ross]

Attachment: Make sidebar 50% wider on Mac

OK, so this makes the sidebar 18em instead of 12em on Mac only (since the left and right sides are set, not the window, we don't lose any width for the channel list - the window gets wider instead). I've tested this with a Windows-specific version of the rule, seems to work fine.

Comment 21

[:Gijs (he/him)]

Comment on attachment 363564 [details] [diff] [review]
Make sidebar 50% wider on Mac

This looks good, but I can't actually test it until I have my macbook back, sorry! :-(

Comment 22

[:Gijs (he/him)]

Comment on attachment 363564 [details] [diff] [review]
Make sidebar 50% wider on Mac

Tad weird (very wide!) but this works fine, thanks a lot!

r=me

Comment 23

[James Ross]

Checked in --> FIXED.