471812 - Cleanup sanitizer code after landing of bug 469158

Status: NEW

(Firefox :: General, defect)

Description

[(no longer active)]

See bug 469158 comment 13

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Also: Sanitizer.sanitize now just calls Sanitizer.showUI, while Sanitizer.prototype.sanitize does the actual work of sanitizing items. The former should probably just be removed, and have callers call showUI directly.

Having some methods on the prototype vs. on the constructor instance is very confusing, and ideally we could clean that up too (and just have a single object).

Comment 2

[Bamm Gabriana]

why is it no longer possible to sanitize without a prompt? in former versions of firefox i can just Ctrl+Shift+Del to clear everything without prompt. now the nasty gui always shows up ignoring my privacy.sanitize.promptOnSanitize settings.

Comment 3

[(no longer active)]

(In reply to comment #2)
> why is it no longer possible to sanitize without a prompt? in former versions
> of firefox i can just Ctrl+Shift+Del to clear everything without prompt. now
> the nasty gui always shows up ignoring my privacy.sanitize.promptOnSanitize
> settings.

This was done in bug 469158.  The reasoning is that with the new design of the Clear Recent History dialog, you need to select a specific time range to clear, and we can't just assume that the user means a specific time range when Ctrl+Shift+Del is pressed.

Comment 4

[Anna Marshall]

Attachment: unverlata19773491.txt

Thanks from acfomuwins1976.