Closed Bug 471821 Opened 16 years ago Closed 16 years ago

TM: Use one lirbuf for the tracer

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
1.9.1 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: gal, Assigned: gal)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 2 obsolete files)

v2, this time with qdiff
4.56 KB, patch
dvander
: review+
Details | Diff | Splinter Review 
This makes lirbuf->names long-lived, which may or may not be an improvement over the status quo. This only affects debugging so I don't think it matters much either way. This saves up to 8k per tree (on average 6k).
Attached patch patch (obsolete) — — Splinter Review 
This also removes the ->shared flag introduced by 471602.
Assignee: general → gal
Blocks: 471602
Attachment #355066 - Flags: review?(dmandelin)
Attachment #355066 - Flags: review?(dmandelin) → review?(danderson)
Attached patch v2 (obsolete) — — Splinter Review 
Must also clear the lirbuf when we flush the code cache.
Attachment #355066 - Attachment is obsolete: true
Attachment #355068 - Flags: review?(danderson)
Attachment #355066 - Flags: review?(danderson)

        Attachment #355068 -
        Attachment is obsolete: true

        Attachment #355069 -
        Flags: review?(danderson)

        Attachment #355068 -
        Flags: review?(danderson)

        Attachment #355069 -
        Flags: review?(danderson) → review+

    
    

    
  
This patch fixes a bug in https://bugzilla.mozilla.org/show_bug.cgi?id=471602, which caused the lirbuf for regular expressions to be never deallocated.

    
    

    
  
Should the bug this blocks be blocking1.9.1+ too?

/be
Flags: blocking1.9.1?

    
    

    
  
Yeah.

    
    

    
  
Yes, this fixed a big jump in our memory footprint.
Flags: blocking1.9.1? → blocking1.9.1+

    
  
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → 1.9.1 Branch
Depends on: 472049
Flags: in-testsuite-
Flags: in-litmus-
Whiteboard: [needs 1.9.1 landing]

    
  
Keywords: fixed1.9.1
Whiteboard: [needs 1.9.1 landing]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: