471836 - don't need to dynamically set Clear Recent History... menu item label

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Bug 469158 removed the option of avoiding the prompt when clearing private data, so there's no reason that we need to set the label to sanitizeWithPromptLabel2 in initializeSanitizer(), since we could instead just update clearRecentHistoryCmd.label accordingly.

Comment 1

[Cork]

Attachment: First try

Comment 2

[Nochum Sossonko [:Natch]]

Comment on attachment 422037 [details] [diff] [review]
First try

I'm not a reviewer (I've requested review from one though), however you have to change the entity id when you change the entity for l10n reasons.

Comment 3

[Cork]

Attachment: v2

Thanks for the comment, i hope this is the change you meant.

Comment 4

[Nochum Sossonko [:Natch]]

That is, only the |.label| part isn't supposed to be the part that is changed, rather the part before the '.'. Change it to something like 'clearRecentHistory.label'.

Comment 5

[Cork]

Should I make the same change to the name of the accesskey entity too, or only the label?

Comment 6

[Cork]

Attachment: v3

Lets start with just the label.

Comment 7

[(no longer active)]

(In reply to comment #5)
> Should I make the same change to the name of the accesskey entity too, or only
> the label?

There are some tools which try to associate the labels and accesskeys, and they usually use try to look for a foorbar.accesskey for each foobar.label.  So, in this case, I would actually suggest changing the accesskey entity name as well, in order to keep these two in sync.

Comment 8

[Cork]

Attachment: v3

Something like this?

I hold on the review request, I don't feel like spamming Gavin any more...

Comment 9

[(no longer active)]

(In reply to comment #8)
> Created an attachment (id=422219) [details]
> v3
> 
> Something like this?

Yes!

Comment 10

[(no longer active)]

Landed on trunk:

http://hg.mozilla.org/mozilla-central/rev/e1ac16b86b80

Thanks for your patch, Cork!