don't need to dynamically set Clear Recent History... menu item label

RESOLVED FIXED in Firefox 3.7a1

Status

()

Firefox
General
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: Gavin, Assigned: Cork)

Tracking

Trunk
Firefox 3.7a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 3 obsolete attachments)

v3
4.63 KB, patch
Gavin
: review+
Details | Diff | Splinter Review
Bug 469158 removed the option of avoiding the prompt when clearing private data, so there's no reason that we need to set the label to sanitizeWithPromptLabel2 in initializeSanitizer(), since we could instead just update clearRecentHistoryCmd.label accordingly.
Blocks: 469158

Updated

8 years ago
Whiteboard: [good first bug]
(Assignee)

Comment 1

8 years ago
Created attachment 422037 [details] [diff] [review]
First try
Attachment #422037 - Flags: review?
Comment on attachment 422037 [details] [diff] [review]
First try

I'm not a reviewer (I've requested review from one though), however you have to change the entity id when you change the entity for l10n reasons.
Attachment #422037 - Flags: review? → review?(gavin.sharp)
(Assignee)

Comment 3

8 years ago
Created attachment 422106 [details] [diff] [review]
v2

Thanks for the comment, i hope this is the change you meant.
Attachment #422037 - Attachment is obsolete: true
Attachment #422106 - Flags: review?(gavin.sharp)
Attachment #422037 - Flags: review?(gavin.sharp)
That is, only the |.label| part isn't supposed to be the part that is changed, rather the part before the '.'. Change it to something like 'clearRecentHistory.label'.
Assignee: nobody → Cork
(Assignee)

Comment 5

8 years ago
Should I make the same change to the name of the accesskey entity too, or only the label?
(Assignee)

Comment 6

8 years ago
Created attachment 422111 [details] [diff] [review]
v3

Lets start with just the label.
Attachment #422106 - Attachment is obsolete: true
Attachment #422111 - Flags: review?(gavin.sharp)
Attachment #422106 - Flags: review?(gavin.sharp)

Comment 7

8 years ago
(In reply to comment #5)
> Should I make the same change to the name of the accesskey entity too, or only
> the label?

There are some tools which try to associate the labels and accesskeys, and they usually use try to look for a foorbar.accesskey for each foobar.label.  So, in this case, I would actually suggest changing the accesskey entity name as well, in order to keep these two in sync.
(Assignee)

Comment 8

8 years ago
Created attachment 422219 [details] [diff] [review]
v3

Something like this?

I hold on the review request, I don't feel like spamming Gavin any more...
Attachment #422111 - Attachment is obsolete: true
Attachment #422111 - Flags: review?(gavin.sharp)

Comment 9

8 years ago
(In reply to comment #8)
> Created an attachment (id=422219) [details]
> v3
> 
> Something like this?

Yes!
(Assignee)

Updated

8 years ago
Attachment #422219 - Flags: review?(gavin.sharp)
Attachment #422219 - Flags: review?(gavin.sharp) → review+

Comment 10

8 years ago
Landed on trunk:

http://hg.mozilla.org/mozilla-central/rev/e1ac16b86b80

Thanks for your patch, Cork!
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
You need to log in before you can comment on or make changes to this bug.