471850 - more than one 'Most Visisted' tabs in toolbar when importing bookmarks.html created by autoExportHTML

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Prakash]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3 (.NET CLR 3.0.4506.2152)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3 (.NET CLR 3.0.4506.2152)

I'm using user_pref("browser.places.importBookmarksHTML", true); and user_pref("browser.bookmarks.autoExportHTML", true); settings and these are set forcefully everytime on windows logon to achieve something (Explained in http://forums.mozillazine.org/viewtopic.php?f=38&t=896955)

Problem:
First launch of firefox after upgrade is creating 'Most visited' tab in toolbar and only shutdown of firefox thos changes are exported to bookmark.html. On next launch of Firefox it tries to import bookmarks from bookmarks.html (I'm setting import setting to true and deleting .json files)  and its creating two tabs of 'Most Visited'. I guess this places.sqlite which stores bookmarks is holding one default tab and the one in bookmarks.html is getting added to it. 

I'm using logon script to delete json file and set import setting to true. Everytime a winodws logon is done and firefox is started one extra tab is getting added. Same is the case with "Recently Bookmarked" and "Recent Tags".

Please let me know if there is quick workaround for this problem. I planned to deploy firefox to few users in our organization tomorrow and then suddenly stuck up with this problem.

Thanks,
Prakash


Reproducible: Always

Steps to Reproduce:
1. first launch of firefox after upgrade and close firefox
2. set import bookmarks setting to 'true', delete .json files (bookmarks backup)
3. launch firefox and it gives two 'most visited' tabs 
4. extra tab gets added each time you do the same

Comment 1

[Marco Bonardo [:mak]]

setting browser.places.smartBookmarksVersion to -1 will disable smart bookmarks creation

Comment 2

[Prakash]

It doesn't seem to be working. 

I've set 
user_pref("browser.bookmarks.autoExportHTML", true);
user_pref("browser.places.importBookmarksHTML", true);
user_pref("browser.places.smartBookmarksVersion", -1);

even tried
user_pref("extensions.tabmix.checkIfBookmarkTabExists", true);

but the problem explained in #1 persists.

Comment 3

[Marco Bonardo [:mak]]

we should probably detect if autoExport is set and disable smart bookmarks by ourselves, and avoid to overwrite the pref if it is set to -1.
I'm confirming the bug.

Comment 4

[Prakash]

any other workaround? If not, I will have to leave importBookmarksHTML setting to false (shouldn't force change to true) after first launch so that multiple tabs are not created due to import. But that doesn't serve my purpose explained in http://forums.mozillazine.org/viewtopic.php?f=38&t=896955.

Comment 5

[Marco Bonardo [:mak]]

browser.places.smartBookmarksVersion is overwritten with 0 if we are about to import from bookmarks.html, so atm i can't see a workaround.

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 7

[Dietrich Ayala (:dietrich)]

Comment on attachment 356175 [details] [diff] [review]
patch v1.0

r=me

Comment 8

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/ccd12ae3f34d

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 356175 [details] [diff] [review]
patch v1.0

asking approval for 1.9.1, this is needed to allow users to disable smart bookmarks (for someone a privacy concern). low risk

Comment 10

[Prakash]

Hello people,

Even if this fixed, should I upgrade to the latest version or can this be integrated in the version I'm using now (3.0.3)?
After this is fixed can I use and import and export bookmarks settings with the smart bookmarks getting duplicated?

Comment 11

[Prakash]

hello guys, could someone please answer this?

Comment 12

[Marco Bonardo [:mak]]

this "could" get into 3.1 if approved, not in 3.0.x, sorry i don't understand the second question...

Comment 13

[Marco Bonardo [:mak]]

this is wanted imo, since in some case we could create smart bookmarks at every browser start, polluting bookmarks menu and the toolbar. And there's no workaround

Comment 14

[Marco Bonardo [:mak]]

oh i forgot this has already a test on trunk, that is currently disabled on branch due the lack of this approval, so when pushing to trunk remember to enable the test in test_browserGlue_prefs.js

Comment 15

[Marco Bonardo [:mak]]

s/when pushing to trunk/when pushing to branch/

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 356175 [details] [diff] [review]
patch v1.0

a191=beltzner

Comment 17

[Marco Bonardo [:mak]]

Attachment: for 1.9.1 (re-enable tests)

Comment 18

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/33ce0269a939

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Verified fixed on trunk and 1.9.1 based on passed unit tests.

Comment 21

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv