Closed Bug 471920 Opened 11 years ago Closed 11 years ago

Workers: 404 errors when creating a new worker silently fails

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

Attached patch Patch, v1 (obsolete) — Splinter Review
Checking the status of the request isn't sufficient when the server returns a 404. We also have to check the 'requestSucceeded' attribute on the http channel. Gah. See http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/public/nsIHttpChannel.idl#216 for the details.
Flags: blocking1.9.1?
Attachment #355167 - Flags: superreview?(jst)
Attachment #355167 - Flags: review?(jst)
Flags: blocking1.9.1? → blocking1.9.1+
Attachment #355167 - Flags: superreview?(jst)
Attachment #355167 - Flags: superreview+
Attachment #355167 - Flags: review?(jst)
Attachment #355167 - Flags: review+
Here's what I actually pushed. Only difference is a slightly nicer error message ("script file not found" vs. the error code only) and a test.
Attachment #355167 - Attachment is obsolete: true
Attachment #355324 - Flags: superreview+
Attachment #355324 - Flags: review+
Pushed changeset 821fc740d5c9 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Pushed changeset 58a487edd274 to mozilla-1.9.1.
Keywords: fixed1.9.1
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.